561328 - "Searching..." from status bar doesn't disappear after search (quick filter bar) is completed on a virtual folder (saved search folder)

Status: RESOLVED WORKSFORME

(Thunderbird :: Search, defect)

Description

[Nomis101]

If you use the new filter bar to filter your messages you will see "Searching..." in the status bar of the main window. But this doesn't disappear if you exit the search or change you inboxes.

STR:
1. Go to your inbox. In the quick filter bar choose something to filter your messages
--> You will see "Searching..." in the status bar
2. Deselect all filters
--> You still see "Searching..."
3. Change from this inbox to another inbox
--> You still see "Searching..."


If filtering isn't used anymore "Searching..." should disappear to clarify that the messages are not filtered anymore.


Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.5pre) Gecko/20100423 Lanikai/3.1b2pre

Comment 1

[Wayne Mery (:wsmwk)]

should this be considered a regression? 
I see this also. Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.5pre) Gecko/20100420 Lanikai/3.1b2pre

Comment 2

[Joe Sabash [:JoeS1]]

This has caused a few questions in support and is still present in current trunk.
It happens also outside the scope of the quick search bar.

Case 1
Click on a virtual folder
Case 2
Click on a sub-folder (this only happens on some sub-folders)

Comment 3

[Wayne Mery (:wsmwk)]

with current trunk I couldn't reproduce using comment 0 except with local folders.
But can reproduce using comment 2's virtual folders saved in imap and local accounts. 

status bar clears after clicking an imap folder.

Comment 4

[Wayne Mery (:wsmwk)]

perhaps this is the same as bug 331399

Also, I can more easily reproduce this in unified folder mode, where I see both
 Searching...
and
 Searching folder...

Comment 5

[Nomis101]

(In reply to comment #3)
> with current trunk I couldn't reproduce using comment 0 

Yes, I also can't reproduce this anymore with my steps. Seems it was fixed in the meantime.

Comment 6

[:aceman]

Let's have bug 573325 for the normal folder case, which seems fixed.

But I can confirm this still happens in TB8 on a Virtual folder. So let's keep this bug for it.

Comment 7

[Nomis101]

Yes, you are right. I also see this. But with my STR from comment 0  I'm now able to again reproduce it with TB 11. So, whatever it fixed in #5, the issue seems now back. :-(

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to :aceman from comment #6)
> Let's have bug 573325 for the normal folder case, which seems fixed.
> 
> But I can confirm this still happens in TB8 on a Virtual folder. So let's
> keep this bug for it.

should we close bug 331399?

Comment 9

[Mitra Ardron]

Re Comment #6 and Bug #573325 this bug hasn't been fixed, or its been un-fixed and still happens.

Comment 11

[b5]

https://github.com/Betterbird/thunderbird-patches/blob/main/102/bugs/561328-clear-searching-status-when-messages-loaded.patch

Comment 12

[BB]

Attachment: 561328-clear-searching-status-when-messages-loaded.patch

Comment 13

[Magnus Melin [:mkmelin]]

Comment on attachment 9331105 [details] [diff] [review]
561328-clear-searching-status-when-messages-loaded.patch

Review of attachment 9331105 [details] [diff] [review]:
-----------------------------------------------------------------

I can't reproduce the bug (I get no feedback at all for search from the quick filter bar actually).

::: mail/base/content/folderDisplay.js
@@ +1168,5 @@
>     */
>    onMessagesLoaded(aAll) {
>      this._allMessagesLoaded = aAll;
>  
> +    if (this._tabInfo) {

This would never do anything anymore. folderDisplay.js is just used in the search dialog and that doesn't have tabs

Comment 14

[BB]

Comment on attachment 9331105 [details] [diff] [review]
561328-clear-searching-status-when-messages-loaded.patch

Thanks for checking the patch. Looks like another bad rebase to 115. Apologies! This was working fine in 102, and as you can see from the report from 2010, feedback was received and never cleared. setTabThinking() is not used in 115 any more, so no surprise there isn't any feedback. It was used in 102 here
https://searchfox.org/comm-esr102/rev/2b139c2a151e752af00df27c464006657143e112/mail/base/content/folderDisplay.js#983
in onSearching(). We filed bug 1831500 and suggest to close this bug here.

Comment 15

[BB]

Likely bug 573325 is also no longer occurring.

Comment 16

[Hartmut Welpmann [:welpy-cw]]

Since 115 this is no longer relevant.