No feedback received during quick search of normal and virtual folders (setTabThinking() now unused)
Categories
(Thunderbird :: Search, defect)
Tracking
(thunderbird_esr102 unaffected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr102 | --- | unaffected |
People
(Reporter: betterbird.project, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: regression, ux-userfeedback, Whiteboard: [Supernova3p])
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68
Steps to reproduce:
From bug 561328 comment #14:
setTabThinking() is not used in 115 any more,
https://searchfox.org/comm-central/search?q=setTabThinking&path=&case=false®exp=false
so there isn't any feedback. It was used in 102 here
https://searchfox.org/comm-esr102/rev/2b139c2a151e752af00df27c464006657143e112/mail/base/content/folderDisplay.js#983
in onSearching().
Also see bug 573325 (and bug 561328 as mentioned).
|
||
Updated•1 year ago
|
Here's a summary of the observed behaviour.
TB 102:
- Quick filter on normal folder: Correct visual feedback in thread pane, status bar: "Searching...", not cleared when search is done. Bug 573325.
- (Folder search on normal folder: Correct visual feedback in "Search Messages" dialogue.)
- When search folder is opened: "Searching...", not cleared when search is done.
- Quick filter on search folder: Same behaviour as point 1. Bug 561328.
The patch in attachment 9331105 [details] [diff] [review] (attached to bug 561328) fixes points 1, 3 and 4. in version 102.
TB 114 (5-5-2023): 1. 3. 4.: No feedback. 2. (Correct as in TB 102.)
https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1831500-feedback-during-search.patch
This reinstates the feedback in the status bar, it includes parts of attachment 9331105 [details] [diff] [review]. For some reason, the "Searching..." doesn't always show, but it was the same in 102.
No feedback in the thread pane. Looks like the code was commented-out and never re-instated:
https://searchfox.org/comm-central/rev/5064e6688c96472afa051130b2c358f9aba0ce56/mail/themes/shared/mail/quickFilterBar.css#152-166
Also see:
https://searchfox.org/comm-central/rev/5064e6688c96472afa051130b2c358f9aba0ce56/mail/base/content/quickFilterBar.js#215-232
Updated our patch to re-instate and improve the CSS. Also fixes a problem here.
|
||
Comment 5•1 year ago
|
||
The problem at
https://searchfox.org/comm-central/rev/abcec1eac4de120d10ce59a8efbb94152ee683c1/mail/base/content/quickFilterBar.js#217-222
was also noticed in bug 1830550 comment #2. Sadly the fix was to remove the code instead of fixing it. Our patch only applies after a backout out that bug and restoring the matches/nomatches attribute. which is needed for the feedback.
|
||
Updated•7 months ago
|
Description
•