562760 - Language packs do not show up as installed

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100427 Minefield/3.7a5pre

There is no way to install language packs into Firefox. There is no entry visible inside the Languages pane.

Steps:
1. Go to http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/
2. Click on an XPI and start the installation

After the language pack has been installed, no entry in the Language pane is visible, even not after a restart.

Comment 1

[Dave Townsend [:mossop]]

Looks like the UI is looking for add-ons of type "language" and the API is calling them "locale", not sure which makes most sense right now.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #1)
> Looks like the UI is looking for add-ons of type "language" and the API is
> calling them "locale", not sure which makes most sense right now.

CC'ing Axel to see if he has a promptly idea.

Comment 3

[Axel Hecht [:Pike]]

Well, the language pack itself claims to be an "8".

Comment 4

[Robert Kaiser]

(In reply to comment #1)
> Looks like the UI is looking for add-ons of type "language" and the API is
> calling them "locale", not sure which makes most sense right now.

Well, we've been using "locale" internally for ages, and the chrome URL and type for language support is also called "locale", so it would be most consistent to use that here as well, I guess.

Just my 2c.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dave, would it be possible to get this fixed for our next testday mid of June?

Comment 7

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Standardises on locale.

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 449293 [details] [diff] [review]
patch rev 1

I assume we still want to keep it exposed to the user as "Languages", rather than "Locales".

Comment 9

[Dave Townsend [:mossop]]

(In reply to comment #8)
> (From update of attachment 449293 [details] [diff] [review])
> I assume we still want to keep it exposed to the user as "Languages", rather
> than "Locales".

Up to Boriss really, and covered by bug 565300, but as Robert says we've been using locale for a long time internally so I think it makes sense to continue to do so.

Comment 10

[Axel Hecht [:Pike]]

My personal take on the naming - the correct technical term is 'locale', and IMHO, we should use that in the code. "Language" should be close enough for the UI, but a localization note on the somewhat ambiguous use would be good. I'll watch bug 565300, too

Comment 11

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/5ca801749b47

Comment 12

[Ben Parr [:bparr]]

The patch that landed broke some things causing there to still be no visible entry for language packs:
- language category is never shown even if a language pack is installed
- localized header text of language category is no longer hooked up correctly (looks for "header-locale" instead of "header-language")

Comment 13

[Ben Parr [:bparr]]

Attachment: Second Patch

This is a very quick fix for both of the points I mentioned in the previous comment. The fix for the second problem is really just a band-aid for a larger problem: the Add-ons Managers uses "language" through-out the code (theme, localization, etc.). As Axel said, we should probably change the code to use "locale" to avoid stuff like this.

Comment 14

[Dave Townsend [:mossop]]

Comment on attachment 450251 [details] [diff] [review]
Second Patch

Thanks for catching this Ben, however rather than working out headerName let's just rename the string in the localization properties file for clarity.

Comment 15

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 450251 [details] [diff] [review]
Second Patch

Looks like this patch should also fix bug 571200.

Comment 16

[Ben Parr [:bparr]]

Attachment: Second Patch v2

Also fixes Bug 571200.

Comment 17

[Dave Townsend [:mossop]]

Comment on attachment 450514 [details] [diff] [review]
Second Patch v2

Great, thanks

Comment 18

[Dave Townsend [:mossop]]

Landed the follow-up as http://hg.mozilla.org/mozilla-central/rev/63f5ac31b8c4

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Too late for a5. Moving TM to 1.9.3 until we have an own entry for beta1.

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a6pre) Gecko/20100610 Minefield/3.7a6pre

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given the discussion with Blair for an automated test for bug 553483 we should probably also mark this for in-testsuite inclusion. It would simply be a part of the test for bug 553483. Beside those tests we will also have a manual test which will probably become an FFT test.

Comment 21

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Changing summary to reflect what was really going on.

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Manual test covered by:
https://litmus.mozilla.org/show_test.cgi?id=15220

So the request for an automated test should be declined?

Comment 23

[Dave Townsend [:mossop]]

Tests were added as a part of bug 572561

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #23)
> Tests were added as a part of bug 572561

Would that make the Litmus test obsolete? If yes, I would favor to remove it.

Comment 25

[Dave Townsend [:mossop]]

(In reply to comment #24)
> (In reply to comment #23)
> > Tests were added as a part of bug 572561
> 
> Would that make the Litmus test obsolete? If yes, I would favor to remove it.

Yes, I would agree

Comment 26

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Litmus test has been disabled. I think it's the right decision because finding the corresponding language pack will always be hard and error prone.