565294 - Update Thunderbird to work with the new add-ons manager

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Shadow912]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100512 Shredder/3.2a1pre BuildID: 20100512033154

When drop an extension .xpi file to Add-ons Manager dialog or message pane, Opening file dialog is shown instead of Software Installation.

on error console:
Error: this.installListeners is null
Source File: file:///F:/Mozilla/Shredder/modules/AddonManager.jsm
Line: 532


Reproducible: Always

Steps to Reproduce:
1. select Tools > add-ons, to open Add-ons Manager
2. drop an extension .xpi file to Add-ons Manager or message pane
3.
Actual Results:  
show Opening file dialog

Expected Results:  
show Software Installation dialog

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Are you talking about Firefox or Thunderbird?

Comment 2

[Shadow912]

Sorry, about Shredder: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.9.3a5pre) Gecko/20100512 Shredder/3.2a1pre BuildID: 20100512033154

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dave, needs Thunderbird the same updates similar to SeaMonkey? If yes, do we have it already tracked somewhere?

Comment 4

[Dave Townsend [:mossop]]

Yeah at the very minimum packaging changes will be requires. This error indicates that addonManager.js isn't shipping right now.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> Yeah at the very minimum packaging changes will be requires. This error
> indicates that addonManager.js isn't shipping right now.

We added it to our shipping data as soon as you relanded the add-on manager and before the first nightly build with it in.

Comment 6

[Dave Townsend [:mossop]]

Ok I'll take a closer look to see what is going on here then.

Comment 7

[Dave Townsend [:mossop]]

I can't really reproduce this problem and though trunk Shredder seems horribly broken on my system it doesn't look to be add-on manager related brokenness.

Can you look and confirm if the file F:\Mozilla\Shredder\components\addonmanager.js actually exists on your machine?

Comment 8

[Shadow912]

(In reply to comment #7)
> I can't really reproduce this problem and though trunk Shredder seems horribly
> broken on my system it doesn't look to be add-on manager related brokenness.
> 
> Can you look and confirm if the file
> F:\Mozilla\Shredder\components\addonmanager.js actually exists on your machine?

Yes, it exist.
I'm updating trunk/Shredder everyday by Help > Check for Update...
Is this module file past nightly build's ?

Comment 9

[Mark Banner (:standard8)]

(In reply to comment #7)
> I can't really reproduce this problem and though trunk Shredder seems horribly
> broken on my system it doesn't look to be add-on manager related brokenness.

That's strange, it shouldn't be that bad...

For the message pane/content tab part of this bug, I think we are probably looking at needing to port the browser parts of:

http://hg.mozilla.org/mozilla-central/rev/704046d2ddea

However, I'm also not sure why our lightweight theme installation tests aren't broken?

If the xpinstall-install-blocked has been removed, shouldn't that be the case?

Also, I'm not sure why the add-on manager part of this bug is broken, unless that requires a notification bar to work correctly?

Comment 10

[Dave Townsend [:mossop]]

(In reply to comment #9)
> (In reply to comment #7)
> > I can't really reproduce this problem and though trunk Shredder seems horribly
> > broken on my system it doesn't look to be add-on manager related brokenness.
> 
> That's strange, it shouldn't be that bad...
> 
> For the message pane/content tab part of this bug, I think we are probably
> looking at needing to port the browser parts of:
> 
> http://hg.mozilla.org/mozilla-central/rev/704046d2ddea

I think that is the case

> However, I'm also not sure why our lightweight theme installation tests aren't
> broken?
> 
> If the xpinstall-install-blocked has been removed, shouldn't that be the case?

Lightweight theme installs don't use the xpinstall-install-blocked notification, at least not in Firefox anyway.

> Also, I'm not sure why the add-on manager part of this bug is broken, unless
> that requires a notification bar to work correctly?

We haven't actually added support for dropping files on the new add-ons manager yet, we should do that, filed bug 565682. It shouldn't do anything in Thunderbird (and doesn't in my test), not open a file dialog. It works in Firefox by virtue of the fact that dropping a file on a browser just attempts to navigate the browser to that file at which point the content handlers dive in.

Comment 11

[Mark Banner (:standard8)]

(In reply to comment #10)
> (In reply to comment #9)
> > If the xpinstall-install-blocked has been removed, shouldn't that be the case?
> 
> Lightweight theme installs don't use the xpinstall-install-blocked
> notification, at least not in Firefox anyway.

You're right, it was the add-on installation being blocked, and the test that I've got for that isn't checked in at the moment as it doesn't work right.

Comment 12

[Peter Lairo]

FWIW: Currently, none of my add-ons are working; the add-on manager doesn't list any add-ons; and I cannot install any add-ons. I miss Lightning most.

Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100514 Shredder/3.2a1pre

Comment 13

[Shadow912]

on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100514 Shredder/3.2a1pre BuildID: 20100514033826,

Case 1, drop a .xpi file to message pane:
 Show Software Installation dialog.
 Succeed in installation.
 Works good.

Case 2, drop a .xpi file to add-ons manager:
 Inhibit to drop. 

(In reply to comment #12)
> FWIW: Currently, none of my add-ons are working; the add-on manager doesn't
> list any add-ons; and I cannot install any add-ons. I miss Lightning most.
> 
> Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre)
> Gecko/20100514 Shredder/3.2a1pre

Until yesterday's nightly build, It was such a situation.
But WFM on today's nightly build.

Comment 14

[Justin Wood (:Callek)]

Attachment: [checked in] Pref Part

Update the prefs.

Comment 15

[Mark Banner (:standard8)]

Comment on attachment 445574 [details] [diff] [review]
[checked in] Pref Part

r=Standard8, no sr required for mailnews patches.

Comment 16

[Mark Banner (:standard8)]

Comment on attachment 445574 [details] [diff] [review]
[checked in] Pref Part

http://hg.mozilla.org/comm-central/rev/6ff37a83320b

Comment 17

[Shadow912]

I've confirmed this issue was fixed on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a6pre) Gecko/20100611 Shredder/3.2a1pre BuildID: 20100611033825 .

> Case 1, drop a .xpi file to message pane:
>  Show Software Installation dialog.
>  Succeed in installation.
>  Works good.

No problem, Thanks all.

> Case 2, drop a .xpi file to add-ons manager:
>  Inhibit to drop. 

But can't drop a .xpi file to Extensions pane on Add-ons Manager, be able to drop to "Get Add-ons" pane.

Comment 18

[Mark Banner (:standard8)]

Attachment: [checked in] The fix

Ok, so add-on manager is at least listing extensions in my dev build, but not in my nightly. Turns out it isn't a good idea to be removing components at the same time as trying to package them...

Comment 19

[Phil Ringnalda (:philor)]

Comment on attachment 450660 [details] [diff] [review]
[checked in] The fix

I always wondered what would happen if you did that...

Comment 20

[Mark Banner (:standard8)]

Comment on attachment 450660 [details] [diff] [review]
[checked in] The fix

Checked in: http://hg.mozilla.org/comm-central/rev/d3df41f2094e

I'm going to leave this bug open until tomorrow's nightly so that I can check what will be working. There will probably be a follow-up bug anyway.

Comment 21

[Shadow912]

on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a6pre) Gecko/20100612 Shredder/3.2a1pre BuildID: 20100612054241,
ChangeSet/SourceStamp: e9eec95e5861

It's the same situation as Comment 17 and Add-ons Manager is listing extensions.
All installed extensions work good.

Comment 22

[Mark Banner (:standard8)]

This is now fixed - the partial update didn't apply but that's just because we had messed up the packaging previously, so the complete update applied fine.

I've filed bug 571759 for moving the add-on manager into a content tab. We'll file other follow-ups in toolkit or Thunderbird as appropriate.

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ludo, can you please check if everything is fixed for Thunderbird now?