566194 - safe mode / security & compatibility check status are not exposed in new addon manager UI

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[(mostly gone) XtC4UaLL [:xtc4uall]]

* start Firefox in safe mode and/or
* set extensions.checkCompatibility.xxx to false and start Firefox and/or
* set extensions.checkUpdateSecurity to false and start Firefox.

in old addons manager UI there's a notification bar shown stating that safe mode is enabled and if you disabled the security or compatibility checks.

in the new addons manager this kind of information missing.

Comment 1

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Reference pic: Firefox 3 add-ons manager gives safe-mode warning

Comment 2

[Jennifer Morrow [:Boriss] (UX)]

Let's treat this in exactly the same way as before for now - a top level in-content notification on each pane of the add-ons manager that says "All add-ons have been disabled by safe mode."

Comment 4

[Dave Townsend [:mossop]]

I think Boriss has covered this.

Comment 5

[Dave Townsend [:mossop]]

Needed by string freeze

Comment 6

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: Global warning over list view for save mode

The attached mock shows a warning over Extensions in list view.  This is the organization bar for current list view - a similar bar would need to be added in Appearance view.

It may seem unusual to repurpose this area for a warning.  I tried a few alternatives, such as placing the warning over the entire section between forward/back and search (shown in mock).  However, this is awkward to color correctly and would only be a temporary solution, as breadcrumb navigation will be placed in this area in Firefox 4.n.  I also tried adding a bar under and over the current bar, but this looked visually redundant.  Though it's a bit unusual, I'm thus recommending we use this area to show a warning and otherwise leave the Name/Last Updated sorting widgets untouched.

We may need a similar warning here if we can add an option under the Gear menu to disable add-ons while already within Firefox.

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Known issues: Doesn't crop or wrap. Not sure why, but unless there's something obvious I'm missing that can be fixed very quickly, I'd like to fix that in a followup.

I'm purposefully not adding any warnings to the discovery pane. My reasoning is that you're not managing your local addons there, so none of the warnings are relevant. But it *is* displaying such warnings in remote search, because its a surprise to have them appear/disappear based on how you're filtering the search results (as opposed to navigating somewhere).

And as far as I know, there's no way to test safe mode, so that will need to be a litmus test.

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1.1

Oops - previous patch was missing a file in pinstripe, and had an additional file in winstripe. Fixed.

Comment 9

[Dave Townsend [:mossop]]

Looks good but can you give me a diff ignoring whitespace changes. Also is there any reason we can't just include the warning once above the view deck?

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #9)
> Also is
> there any reason we can't just include the warning once above the view deck?

Only the details pane would be able to use it (other panes have the warnings in existing containers). But also, if it were outside the deck, then we'd need to hide/show it based on what the current view was - which seems a bit messy. The way the patch does it, the warnings can be fitted in based on where it makes sense for each view type. This will also make it easy to add them to the revamped appearance pane (when its eventually done), which will be different again.

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1.1 - no whitespace changes

Comment 12

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/mozilla-central/rev/bb55a00afa1d

Comment 13

[(mostly gone) XtC4UaLL [:xtc4uall]]

As it has been implemented now, the Notification Bar Text is not dismiss-able as it has been in the old AOM.

Hence in the "worst Case" of Safe-Mode: on + Compatibility Check: off + Update Security Check: off, only the Safe-Mode State is exposed, there other two are not.
With only Compatibility Check: off + Update Security Check: off, you only get the Security Check State exposed, the other one isn't.

Despite the Fact that this should be okay/sufficient with Fx4, I'm asking beforehand if it's useful/worthwhile to file a Follow-Up to get this done properly, i.e. are there yet Post-Fx4-Plans on this Issue?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

(In reply to comment #13)
> Hence in the "worst Case" of Safe-Mode: on + Compatibility Check: off + Update
> Security Check: off, only the Safe-Mode State is exposed, there other two are
> not.
>
> With only Compatibility Check: off + Update Security Check: off, you only get
> the Security Check State exposed, the other one isn't.

I would say file a new bug on both items. Bugs are cheap and discussion is better handled on non-fixed bugs.

Marking as verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100917 Firefox/4.0b7pre

Blair, what should be tested by a manual test?

Comment 15

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #13)
> Despite the Fact that this should be okay/sufficient with Fx4, I'm asking
> beforehand if it's useful/worthwhile to file a Follow-Up to get this done
> properly, i.e. are there yet Post-Fx4-Plans on this Issue?

Yea, as Henrik suggests, file a new bug. We'll figure out what, if anything, we can do to improve it post-4.0.

(In reply to comment #14)
> Blair, what should be tested by a manual test?

Only need the safe-mode notification needs manually tested. The other notifications are tested with browser-chrome tests.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Manual test covered by:
https://litmus.mozilla.org/show_test.cgi?id=15315