567250 - Locale-specific-Featured-add-ons are not honored in zamboni

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.As an admin,go to Feature Manager->Category Features
2.Restrict one featured add-on to a particular locale(flagfox to es-ES)
3.Navigate to https://preview.addons.mozilla.org/en-US/firefox/extensions/alerts-updates/featured

expected result:
Flagfox is not featured for en-US


actual result:
Flagfox is featured for en-US

Comment 1

[Wil Clouser [:clouserw]]

This is a good catch, but the feature isn't used at all in production.  Kicking to 4.x.

Comment 2

[Wil Clouser [:clouserw]]

clouserw "I'm marking this as [bonus] because we'll get this for free when we redo the admin tools."
fligtar, sarcastically "yeah, that makes sense"

Comment 3

[Wil Clouser [:clouserw]]

We need these to work sooner than we need the admin tools.

Comment 4

[Andy McKay]

Does this apply to just extensions/alerts-updates/featured or does it have a wider scope than that page?

Comment 5

[Jeff Balogh (:jbalogh)]

(In reply to comment #4)
> Does this apply to just extensions/alerts-updates/featured or does it have a
> wider scope than that page?

The most important place for this is /featured. Category pages are very secondary.

Comment 6

[Justin Scott [:fligtar]]

We should do this for all featured areas; it's a regression that we don't support it.

Also note that the way this feature works is that we rank locale-specific add-ons higher than unspecified locale add-ons, not that we entirely exclude them.

For example, if the featured set is:
de: German Adblocker, Wienerschnitzel Locator, Germany Toolbar
unspecified: Adblock Plus, Flagfox, Password Exporter

and we have 3 featured slots to fill, we'd show the 3 de add-ons randomly ordered.

If we had 5 slots to fill, we'd choose the 3 de add-ons randomly ordered and then 2 unspecified locale add-ons randomly.

Comment 7

[Andy McKay]

Note for myself and QA, pages changed so far:

/
/featured
/extensions/[category]/ (it has featured at the top)
/extensions/[category]/featured
/personas/[category]

Comment 8

[Wil Clouser [:clouserw]]

Andy tells me this is in.  -> fixed

Comment 9

[krupa raj[:krupa]]

Filed bug 629095 and bug 629419

Checked that-

* adding locale-specific featured add-ons works
* adding locale-specific creatured add-ons work
* locale-specific featured add-ons are listed only for that locale
* locale-specific creatured add-ons are listed only for that locale
* locale-specific add-ons are listed before unspecified add-ons

creatured add-ons are not supported for search tools. See bug 605670 for details.