572695 - Remove "Report a Broken Website" from Firefox

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Aakash Desai [:aakashd]]

We need code removal of the Reporter code located here:

http://mxr.mozilla.org/mozilla-central/source/extensions/reporter/

before we ship Fx 4 Beta 1....nominating!

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Do we have a bug about replacing it with something?

For Firefox 4 betas we'll have the Feedback Add-On, but afterwards do we not want a general "Give us feedback..." button?

Comment 2

[Aakash Desai [:aakashd]]

I doubt it. SUMO is the right outlet for feedback on final updates of Firefox as the expectations on what we can do with feedback collected changes. 

I believe it goes from fixing issues before the browser is released to offering-ideas(I need to talk to Tenser about this)/explaining-new-features/top-issues after the browser is released.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Oh, wow, I couldn't disagree more with that comment, but that's a discussion for another time I suppose.

Comment 4

[Aakash Desai [:aakashd]]

Interesting; yeah, we'll need to talk about this.

Comment 5

[Aakash Desai [:aakashd]]

After some thinking and re-reading it over, I now disagree with my own comments :). There's more to this, but yes, let's chat.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

So, I think we want to:

 - unhook the current Reporter (which isn't monitored, and is overly complex)
 - add a new menuItem that brings people to the Feedback website and allows them to report a website that is broken in Firefox

Agree?

Comment 7

[Aakash Desai [:aakashd]]

Yep.

For the second point: The link should be http://input.mozilla.com/sad for the Betas until we get closer to Fx Proper. 

My plan, as it stands right now, will be to change the link to another URL (as we get closer to a release) on Input which is specifically targeted for information gathering from users on the released version when that new feature is ready. You're going to have sign off on the idea and mockups once it's ready to be reviewed.

Comment 8

[:Margaret Leibovic]

Attachment: add "submit feedback..." menu option

The patch replaces the "Report a Broken Web Site..." menu option with a "Submit Feedback..." The new option opens http://input.mozilla.com/sad, as suggested in comment 7, but we need to change that url when a final feedback website is ready.

Comment 9

[Fred Wenzel [:wenzel]]

Hi Margaret, welcome aboard :)

(In reply to comment #8)
> The patch replaces the "Report a Broken Web Site..." menu option with a "Submit
> Feedback..." The new option opens http://input.mozilla.com/sad, as suggested in
> comment 7, but we need to change that url when a final feedback website is
> ready.

Agreed -- the webapp will not currently accept feedback from stable versions of Firefox. But as long as we're still in beta, it'll work.

Comment 10

[:Margaret Leibovic]

I filed bug 588209 to determine the final URL and I assigned it to Aakash. Hopefully that will resolve that issue :)

Comment 11

[Justin Dolske [:Dolske]]

Comment on attachment 466814 [details] [diff] [review]
add "submit feedback..." menu option

What are the plans for the webservice side of things? We should probably actually remove /extensions/reporter at some point, but I guess SeaMonkey is still using it.

The accesskey added here ("F") conflicts with the existing "F" accesskey for Report A Web Forgery... "S" appears to be unused, though.

r+ with that change.

Comment 12

[Aakash Desai [:aakashd]]

> What are the plans for the webservice side of things? We should probably
> actually remove /extensions/reporter at some point, but I guess SeaMonkey is
> still using it.

The plans are listed in the dependency bug for the one that Margaret filed in comment #10. Thanks!

Comment 13

[:Margaret Leibovic]

Attachment: patch-final

Fixed accesskey conflict mentioned in comment 11

Comment 14

[:Margaret Leibovic]

Checkin-needed on final patch

Comment 15

[:Margaret Leibovic]

Attachment: patch-final

Updated patch to apply cleanly

Comment 16

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/cbf5a3941272

Comment 17

[:Margaret Leibovic]

Attachment: patch-final

patch that shouldn't break the build anymore...

Comment 18

[Dave Townsend [:mossop]]

Bustage fix pushed: http://hg.mozilla.org/mozilla-central/rev/2b2686331b2a

Comment 19

[Reed Loden [:reed]]

Comment on attachment 468466 [details] [diff] [review]
patch-final

>+/**
>+ * Opens the feedback page for this version of the application.
>+ */
>+function openFeedbackPage()
>+{
>+  openUILinkIn("http://input.mozilla.com/sad", "tab");
>+}

This should have been put into a pref and not hardcoded in a .js file.

Comment 20

[Mike Hommey [:glandium]]

Adding "Submit feedback" in the help menu with the intent of replacing "Report Broken website" is kind of weird. The result is now I got a user report that he wanted to send a happy feedback, which he can't do with that item (test pilot is disabled on unbranded builds, but anyways, once 4.0 ships, test pilot won't be enabled either)

Comment 21

[Aakash Desai [:aakashd]]

Mike, take a look at Comment #10 and read through the blocker bugs related to that bug. That should offer some help!

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #9)
> Agreed -- the webapp will not currently accept feedback from stable versions of
> Firefox. But as long as we're still in beta, it'll work.

The same applies to nightly builds where you get a useless page:
http://input.mozilla.com/en-US/beta/download

(In reply to comment #19)
> >+function openFeedbackPage()
> >+{
> >+  openUILinkIn("http://input.mozilla.com/sad", "tab");
> >+}
> 
> This should have been put into a pref and not hardcoded in a .js file.

Margarete, has this been fixed or a follow-up bug filed?

Aakash, do we have follow-up bugs for necessary work to support the final Firefox 4.0 release?

I will have to update the following litmus test once my questions are solved:
https://litmus.mozilla.org/show_test.cgi?id=10064

Comment 24

[:Margaret Leibovic]

There was a follow-up bug to change the url for the feedback page (bug 588209), but I don't believe there was a bug to turn it into a pref.

Comment 25

[Aakash Desai [:aakashd]]

> Aakash, do we have follow-up bugs for necessary work to support the final
Firefox 4.0 release?


Yes, and that's done. You can see the changes by switching your user agent on Firefox 4 to the latest release version (i.e. 3.6.13) and going to input.mozilla.com/feedback.

https://bugzilla.mozilla.org/show_bug.cgi?id=626705

Comment 26

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #25)
> Yes, and that's done. You can see the changes by switching your user agent on
> Firefox 4 to the latest release version (i.e. 3.6.13) and going to
> input.mozilla.com/feedback.

Ok, but there is no way for nightly testers to submit those feedback. Don't we explicitly support that?

Comment 27

[Fred Wenzel [:wenzel]]

We currently explicitly do *not* support that. There's no feedback button in nightlies (there's not supposed to be, anyway) and Input won't support nightly feedback until its 4.x milestones (currently working on 3.1).

Comment 28

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, thanks for the information Fred. Marking as verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10) Gecko/20100101 Firefox/4.0b10

Litmus test has been updated to the renamed menu entry:
https://litmus.mozilla.org/show_test.cgi?id=10064