Classic Skin: Should use CSS system fonts not hardcoded fonts

VERIFIED FIXED in mozilla0.9

Status

SeaMonkey
Themes
P2
normal
VERIFIED FIXED
18 years ago
7 years ago

People

(Reporter: Andrew Thompson, Assigned: andreww)

Tracking

Trunk
mozilla0.9
PowerPC
Mac System 8.5
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
The Mac classic skin currently includes many examples of hardcoded font names 
"Geneva" and "Charcoal" where it should be using the generic CSS 2 system font 
names like "Menu".

This is not a duplication of bug 26288 which is actually about putting fonts into 
the font menu, not into skins.

CSS2 system fonts work fine on Mac OS (I just tried them).

We should be using them in the skin files for Appearance compatibility.

(for more info on system font issues in general:

broken on windows: bug 33312
broken on Linux: bug 33313
should be used in modern skin: bug 16729)
(Reporter)

Updated

18 years ago
Blocks: 49144
(Reporter)

Comment 1

18 years ago
I need to attach fixed CSS files somewhere as I correct this. 
See bug 57490 - I'm going to put the files there I think and just use this bug to 
track this issue.

Comment 2

18 years ago
The fix to this issue will require creating images for buttons and menulists that 
can expand to the size of the font selected in the system.  We cannot fix this 
issue with only css.  I really want to see this issue fixed for Mac Classic and 
Modern...
(Reporter)

Comment 3

18 years ago
That's true but Mac OS only allows a very limited selection of fonts to be used 
for buttons and menus, etc. These deliberately have the same (or v. similar) 
metrics to each other.

I believe of the 6 CSS 2 system fonts only one will be affected by this issue 
because its the only one that Mac OS 9 allows significant changes to.

That said, it is possible to change the OS font size (though not as radically is 
it is on Windows) and again this only effects one of the fonts.

We should still go ahead and do this now - 5 out of 6 fonts will be OK and the 
last will still work better so long as people choose a sensible font.

Comment 4

18 years ago
We have been denied the ability to do this now.  Once we can checkin changes to 
the trunk again we will do fixes like this.  Sending to Andrew.
Assignee: hangas → andreww
(Reporter)

Comment 5

18 years ago
Yes. But you can checkin reviewed patches on the tip as when I find time to write 
them, and get reviewers. I realise this is going to be tricky until after RTM but 
I'll make what headway I can.
(Assignee)

Comment 6

18 years ago
accepting bug.
Status: NEW → ASSIGNED

Comment 7

18 years ago
This should be fixed now (see bug 16729).  Can someone with a Mac verify this?

Comment 8

18 years ago
Ignore my last post, I didn't realize this was related to Mac Classic and not
Modern.

Comment 9

18 years ago
Themes Triage Team nsbeta1+
Keywords: nsbeta1
Priority: P3 → P2
(Assignee)

Comment 10

18 years ago
setting milestone
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 11

18 years ago
setting depends.
Depends on: 51346
(Assignee)

Comment 12

18 years ago
adding ccs 
(Assignee)

Comment 13

18 years ago
adding pink to cc list FYI
(Assignee)

Comment 14

18 years ago
Now that buttons are scalable, I can get to this...
(Assignee)

Comment 15

18 years ago
Created attachment 25814 [details] [diff] [review]
diffs for making mac classic fonts css system fonts
(Assignee)

Comment 16

18 years ago
adding keyword. Patch ready for review.
Keywords: review

Comment 17

18 years ago
r=timeless
Keywords: review → approval

Comment 18

18 years ago
sr=hewitt
(Assignee)

Comment 19

18 years ago
Fix checked into the trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 20

18 years ago
Marking verified on Mac (2001-03-05-08-Mtrunk).
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.