575005 - Status bar disappears when enabling the menu bar

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[pal-moz]

Attachment: screenshot

[STR]
1) View>Toolbars, check Menu Bar
2) Status Bar disappear (View>Status Bar is checked)

Comment 1

[[not reading bugmail]]

Resizing the bottom window border tends to bring it back as sometimes I see it where the status bar turns into glass first before resizing the window from the bottom works.

Comment 2

[Silanea]

Same issue since today's nightly on Windows 2008 x64w/ Aero Glass enabled.

Comment 3

[[not reading bugmail]]

I tried this today with a more recent hourly.  

(In reply to comment #1)
> Resizing the bottom window border tends to bring it back as sometimes I see it
> where the status bar turns into glass first before resizing the window from the
> bottom works.

Going from Menu Bar to Menu button, the status bar was there this time, but this time everything inside the borders appears to shift up the distance of the titlebar border being removed at the top.

Comment 4

[Jim Mathies [:jimm]]

confirmed.

Comment 5

[[not reading bugmail]]

(In reply to comment #3)
> I tried this today with a more recent hourly.  
> 
> (In reply to comment #1)
> > Resizing the bottom window border tends to bring it back as sometimes I see it
> > where the status bar turns into glass first before resizing the window from the
> > bottom works.
> 
> Going from Menu Bar to Menu button, the status bar was there this time, but
> this time everything inside the borders appears to shift up the distance of the
> titlebar border being removed at the top.

Jim, I don't see the block of glass at the bottom of the browser window when flipping between Menubar and Menu button when the toolbars shift up with the test build from bug 575245 comment 62.

Comment 6

[[not reading bugmail]]

Jim, looks like someone filed bug 570260 for the glass change I mentioned.

Comment 7

[[not reading bugmail]]

(In reply to comment #6)
> Jim, looks like someone filed bug 570260 for the glass change I mentioned.

oh, crap..sorry for the spam, that should be bug 575256 instead.

Comment 8

[Josh]

I'm seeing this problem on 4.0b1. When I initially started FF, the status bar wasn't visible and toggling it via the menu did nothing. Resizing the window made it appear. Not being able to see the URL a link goes to is a security problem, IMO, so I use the status bar. Additionally, disabling the menu bar (using the "menu button") causes the status bar to move upwards and makes the window border thicker, as opposed to extending the content area. Re-enabling the menu bar pushes things back down and gives me a normal size border, and resizing the window also fixes it.

Comment 11

[pal-moz]

same or not ?
status bar disappears when switching between Aero Theme and Basic Theme.

Comment 13

[Jim Mathies [:jimm]]

This is a strange bug. Widget is firing off a size event when the client area changes, and we are invalidating the window to force a repaint. But for some reason, content doesn't pick up the size event and adjust it's layout. Possibly due to the fact that the overall window doesn't change size.

Comment 14

[Jim Mathies [:jimm]]

Also, bug 575256 is a dupe of this, but I'll keep them separate for now.

Comment 16

[Jim Mathies [:jimm]]

Attachment: force reflow patch.v1

Comment 17

[Jim Mathies [:jimm]]

Comment on attachment 457713 [details] [diff] [review]
force reflow patch.v1

When callers invoke SetNonClientMargins, we have to force a reflow through some windows trickery, otherwise content never knows the size of the client area has changed. This fixes various reflow bugs related to turning the menu bar on and off, which shows and hides the fx button.

Also, I switched UpdateWindow with Invalidate in UpdateNonClientMargins. Since UpdateWindow will only send a paint event if there's currently an update region. Invalidation insures the window gets repainted.

Comment 18

[pal-moz]

bug 577027 is similar as bug 578942 ?
bug 577027 will be fixed by/with this bug ?

Comment 19

[Jim Mathies [:jimm]]

(In reply to comment #18)
> bug 577027 is similar as bug 578942 ?
> bug 577027 will be fixed by/with this bug ?

pal-moz, can you provide steps to reproduce in that bug? I really have no idea without a way to test against this patch.

Comment 20

[pal-moz]

(In reply to comment #19)
> (In reply to comment #18)
> > bug 577027 is similar as bug 578942 ?
> > bug 577027 will be fixed by/with this bug ?
> 
> pal-moz, can you provide steps to reproduce in that bug? I really have no idea
> without a way to test against this patch.

see bug title.
just switch/change between Aero/Basic Theme.

Comment 21

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/06a815baa315

Comment 22

[pal-moz]

Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100716 Minefield/4.0b2pre ID:20100716040830

still disappear when change Aero Theme to Basic Theme.
fixed if back to Aero Theme.

another bug ?

Comment 23

[Tan Wei Lin Jason [:Ryuji]]

I cannot reproduce the bug that you mention. It appears that this patch has fixed the problem in my Firefox.

Comment 24

[Jim Mathies [:jimm]]

(In reply to comment #22)
> Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100716
> Minefield/4.0b2pre ID:20100716040830
> 
> still disappear when change Aero Theme to Basic Theme.
> fixed if back to Aero Theme.
> 
> another bug ?

Yeah this still happens. (I think there's a bug on this but can't find it at the moment.) This is odd since the theme changed event triggers the same reflow. I'll have to do some digging.

Comment 25

[[not reading bugmail]]

(In reply to comment #24)
> (In reply to comment #22)
> > Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100716
> > Minefield/4.0b2pre ID:20100716040830
> > 
> > still disappear when change Aero Theme to Basic Theme.
> > fixed if back to Aero Theme.
> > 
> > another bug ?
> 
> Yeah this still happens. (I think there's a bug on this but can't find it at
> the moment.) This is odd since the theme changed event triggers the same
> reflow. I'll have to do some digging.

Filed bug 579484 for this in case you don't find it.