Closed
Bug 578422
Opened 15 years ago
Closed 14 years ago
toolbar button styling needs to take lightweight themes into account
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b10
People
(Reporter: dao, Assigned: mstange)
References
Details
(Keywords: regression)
Attachments
(2 files, 2 obsolete files)
8.40 KB,
patch
|
dao
:
review+
beltzner
:
approval2.0+
|
Details | Diff | Splinter Review |
10.12 KB,
image/png
|
Details |
Toolbar buttons used to be slightly transparent (bug 494927). They aren't anymore as of bug 559033.
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #459373 -
Flags: review?(dao)
Updated•14 years ago
|
Flags: in-litmus?(abillings)
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #459373 -
Attachment is obsolete: true
Attachment #497333 -
Flags: review?(dao)
Attachment #459373 -
Flags: review?(dao)
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 497333 [details] [diff] [review]
v2
needs more tweaking
Attachment #497333 -
Flags: review?(dao)
Assignee | ||
Comment 5•14 years ago
|
||
Attachment #497333 -
Attachment is obsolete: true
Attachment #497778 -
Flags: review?(dao)
Reporter | ||
Comment 6•14 years ago
|
||
Comment on attachment 497778 [details] [diff] [review]
v3
Please remove the spaces in rgba() to make these lines easier to parse with the eye.
Attachment #497778 -
Flags: review?(dao) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #497778 -
Flags: approval2.0?
Comment 7•14 years ago
|
||
Comment on attachment 497778 [details] [diff] [review]
v3
a=beltzner
Attachment #497778 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
Comment 9•14 years ago
|
||
The back/forward buttons are looking bad in RTL UI. Was that caused by this patch?
Assignee | ||
Comment 10•14 years ago
|
||
Oops, yes.
Assignee | ||
Comment 11•14 years ago
|
||
I've filed bug 627309.
Updated•13 years ago
|
Flags: in-litmus?(abillings) → in-litmus?
You need to log in
before you can comment on or make changes to this bug.
Description
•