Closed Bug 578422 Opened 11 years ago Closed 10 years ago

toolbar button styling needs to take lightweight themes into account

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b10

People

(Reporter: dao, Assigned: mstange)

References

Details

(Keywords: regression)

Attachments

(2 files, 2 obsolete files)

Toolbar buttons used to be slightly transparent (bug 494927). They aren't anymore as of bug 559033.
Duplicate of this bug: 508761
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attached patch v1 (obsolete) — Splinter Review
Attachment #459373 - Flags: review?(dao)
Flags: in-litmus?(abillings)
Attached patch v2 (obsolete) — Splinter Review
Attachment #459373 - Attachment is obsolete: true
Attachment #497333 - Flags: review?(dao)
Attachment #459373 - Flags: review?(dao)
Comment on attachment 497333 [details] [diff] [review]
v2

needs more tweaking
Attachment #497333 - Flags: review?(dao)
Attached patch v3Splinter Review
Attachment #497333 - Attachment is obsolete: true
Attachment #497778 - Flags: review?(dao)
Comment on attachment 497778 [details] [diff] [review]
v3

Please remove the spaces in rgba() to make these lines easier to parse with the eye.
Attachment #497778 - Flags: review?(dao) → review+
Attachment #497778 - Flags: approval2.0?
Comment on attachment 497778 [details] [diff] [review]
v3

a=beltzner
Attachment #497778 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/a4df433a0caa
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
The back/forward buttons are looking bad in RTL UI. Was that caused by this patch?
Oops, yes.
Depends on: 627309
I've filed bug 627309.
Flags: in-litmus?(abillings) → in-litmus?
You need to log in before you can comment on or make changes to this bug.