Closed Bug 580965 Opened 9 years ago Closed 9 years ago

Vertical lines between non-tab tab bar elements look out of place in the tabs on top mode

Categories

(Firefox :: Theme, defect, minor)

All
macOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 4.0b9

People

(Reporter: hsivonen, Assigned: mstange)

References

Details

Attachments

(4 files, 1 obsolete file)

Steps to reproduce:
 1) Use a Mac
 2) Update to nightly from around 2010-07-21
 3) Make sure "tabs on top" is enabled.

Actual results:
In the right, the three non-tab UI elements are bounded by vertical lines that end sharply at the title bar. The lines don't look right for unified windows, since unified windows generally don't have elements that end sharply at the title bar.

Expected results:
Expected these UI elements not to have the lines around them or, alternatively, expected the lines to fade gradually upwards to make the transition to the title bar look less sharp.
Component: Toolbars → Theme
QA Contact: toolbars → theme
Duplicate of this bug: 594016
Blocks: 544821
Stephen, did the summary change in bug 594016 mean that we should remove the separators in tabs-on-bottom mode, too?
(In reply to comment #2)
> Stephen, did the summary change in bug 594016 mean that we should remove the
> separators in tabs-on-bottom mode, too?

Yes, I think we can remove these in both configurations.
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #494137 - Flags: review?(dao)
Attached image screenshot, tabs on top
Attachment #494138 - Flags: ui-review?(shorlander)
Attachment #494139 - Flags: ui-review?(shorlander)
Comment on attachment 494139 [details]
screenshot, tabs on bottom

Looks good, thank you! We might want to reduce the space between them but if so I will file a follow-up.
Attachment #494139 - Flags: ui-review?(shorlander) → ui-review+
Attachment #494137 - Flags: review?(dao) → review+
Attachment #494137 - Flags: approval2.0?
Attachment #494137 - Flags: approval2.0? → approval2.0+
Attached patch for checkinSplinter Review
Attachment #494137 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/49a1b2aa43c5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b9
may I say that the new pressed/hover states for those elements now looks kind of strange…
(In reply to comment #10)
> may I say that the new pressed/hover states for those elements now looks kind
> of strange…

I agree it looks strange now. I will file a followup bug.
The inner shadow in the pressed state wasn't an intentional change and is not from this bug; it's only there because of unintentional selector specificity change and will be fixed in bug 620059.
You need to log in before you can comment on or make changes to this bug.