Instead of Tabbar.showOnlyTheseTabs, it can be part of tabbrowser. Assuming bug 580847 is fixed to move the tabs to the right places, there shouldn't be a need for the current functionality of reordering tabs when showing only those tabs.
Created attachment 459972 [details] [diff] [review] v1
Seems like Raymond rolled the show functionality into UIManager: http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/b1c26205b38b
(In reply to comment #3) > Seems like Raymond rolled the show functionality into UIManager: > http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/b1c26205b38b Oh, sorry. I saw the comment 2 in bug 581267 and miss this one.
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/11493ab7c276 Move and simplify showOnlyTheseTabs functionality into tabbrowser now that there's no reordering happening on show.
Assignee: nobody → edilee
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Summary: Add show Tabs functionality to tabbrowser → Add showOnlyTheseTabs functionality to tabbrowser
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/430dddaaf423 Call updateTabBarForActiveGroup so that Group is correctly set for this.
Comment on attachment 459972 [details] [diff] [review] v1 Looks good except for this line: Utils.timeout(Groups.updateTabBarForActiveGroup, 400); "this" won't be set up properly.
See comment 6.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago → 8 years ago
Resolution: --- → FIXED
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy. Filter the bugmail spam with "tabcandymassmove".
Component: TabCandy → TabCandy
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Documented here: https://developer.mozilla.org/en/XUL/Method/showOnlyTheseTabs https://developer.mozilla.org/en/XUL/Method/showAllTabs Added to the list of methods on tabbrowser here: https://developer.mozilla.org/en/XUL/tabbrowser Linked from Firefox 4 for developers.
Keywords: dev-doc-needed → dev-doc-complete
sheppy, sorry for the confusion, but this bug originally landed as part of the tabcandy-central branch, and the code that landed in m-c is in bug 582116 where there ended up not being a showAllTabs.
Removed showAllTabs from the docs; thanks!
You need to log in before you can comment on or make changes to this bug.