Closed Bug 581612 Opened 12 years ago Closed 12 years ago

Add showOnlyTheseTabs functionality to tabbrowser

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

v1
6.70 KB, patch
iangilman
: review-
iangilman
: feedback-
Details | Diff | Splinter Review
Instead of Tabbar.showOnlyTheseTabs, it can be part of tabbrowser.

Assuming bug 580847 is fixed to move the tabs to the right places, there shouldn't be a need for the current functionality of reordering tabs when showing only those tabs.
Attached patch v1 (obsolete) — Splinter Review
Attachment #459970 - Flags: feedback?(ian)
Attached patch v1Splinter Review
Attachment #459970 - Attachment is obsolete: true
Attachment #459970 - Flags: feedback?(ian)
Seems like Raymond rolled the show functionality into UIManager:
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/b1c26205b38b
(In reply to comment #3)
> Seems like Raymond rolled the show functionality into UIManager:
> http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/b1c26205b38b

Oh, sorry.  I saw the comment 2 in bug 581267 and miss this one.
Blocks: 581736
No longer blocks: 581736
Depends on: 581736
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/11493ab7c276
Move and simplify showOnlyTheseTabs functionality into tabbrowser now that there's no reordering happening on show.
Assignee: nobody → edilee
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: Add show Tabs functionality to tabbrowser → Add showOnlyTheseTabs functionality to tabbrowser
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/430dddaaf423
Call updateTabBarForActiveGroup so that Group is correctly set for this.
Comment on attachment 459972 [details] [diff] [review]
v1

Looks good except for this line:

Utils.timeout(Groups.updateTabBarForActiveGroup, 400);

"this" won't be set up properly.
Attachment #459972 - Flags: review-
Attachment #459972 - Flags: feedback-
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See comment 6.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Blocks: 582116
Blocks: 582872
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
sheppy, sorry for the confusion, but this bug originally landed as part of the tabcandy-central branch, and the code that landed in m-c is in bug 582116 where there ended up not being a showAllTabs.
Removed showAllTabs from the docs; thanks!
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.