581612 - Add showOnlyTheseTabs functionality to tabbrowser

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Ed Lee :Mardak]

Instead of Tabbar.showOnlyTheseTabs, it can be part of tabbrowser.

Assuming bug 580847 is fixed to move the tabs to the right places, there shouldn't be a need for the current functionality of reordering tabs when showing only those tabs.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

Attachment: v1

Comment 3

[Ed Lee :Mardak]

Seems like Raymond rolled the show functionality into UIManager:
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/b1c26205b38b

Comment 4

[Raymond Lee [:raymondlee]]

(In reply to comment #3)
> Seems like Raymond rolled the show functionality into UIManager:
> http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/b1c26205b38b

Oh, sorry.  I saw the comment 2 in bug 581267 and miss this one.

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/11493ab7c276
Move and simplify showOnlyTheseTabs functionality into tabbrowser now that there's no reordering happening on show.

Comment 6

[Ed Lee :Mardak]

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/430dddaaf423
Call updateTabBarForActiveGroup so that Group is correctly set for this.

Comment 7

[Ian Gilman [:iangilman]]

Comment on attachment 459972 [details] [diff] [review]
v1

Looks good except for this line:

Utils.timeout(Groups.updateTabBarForActiveGroup, 400);

"this" won't be set up properly.

Comment 8

[Ed Lee :Mardak]

See comment 6.

Comment 9

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".

Comment 10

[Eric Shepherd [:sheppy]]

Documented here:

https://developer.mozilla.org/en/XUL/Method/showOnlyTheseTabs
https://developer.mozilla.org/en/XUL/Method/showAllTabs

Added to the list of methods on tabbrowser here:

https://developer.mozilla.org/en/XUL/tabbrowser

Linked from Firefox 4 for developers.

Comment 11

[Ed Lee :Mardak]

sheppy, sorry for the confusion, but this bug originally landed as part of the tabcandy-central branch, and the code that landed in m-c is in bug 582116 where there ended up not being a showAllTabs.

Comment 12

[Eric Shepherd [:sheppy]]

Removed showAllTabs from the docs; thanks!