Add showOnlyTheseTabs functionality to tabbrowser

RESOLVED FIXED

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

({dev-doc-complete})

Trunk
dev-doc-complete
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

v1
6.70 KB, patch
iangilman
: review-
iangilman
: feedback-
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Instead of Tabbar.showOnlyTheseTabs, it can be part of tabbrowser.

Assuming bug 580847 is fixed to move the tabs to the right places, there shouldn't be a need for the current functionality of reordering tabs when showing only those tabs.
(Assignee)

Comment 1

7 years ago
Created attachment 459970 [details] [diff] [review]
v1
Attachment #459970 - Flags: feedback?(ian)
(Assignee)

Comment 2

7 years ago
Created attachment 459972 [details] [diff] [review]
v1
Attachment #459970 - Attachment is obsolete: true
Attachment #459970 - Flags: feedback?(ian)
(Assignee)

Comment 3

7 years ago
Seems like Raymond rolled the show functionality into UIManager:
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/b1c26205b38b
(In reply to comment #3)
> Seems like Raymond rolled the show functionality into UIManager:
> http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/b1c26205b38b

Oh, sorry.  I saw the comment 2 in bug 581267 and miss this one.
(Assignee)

Updated

7 years ago
Blocks: 581736
(Assignee)

Updated

7 years ago
No longer blocks: 581736
Depends on: 581736
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/11493ab7c276
Move and simplify showOnlyTheseTabs functionality into tabbrowser now that there's no reordering happening on show.
Assignee: nobody → edilee
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Summary: Add show Tabs functionality to tabbrowser → Add showOnlyTheseTabs functionality to tabbrowser
(Assignee)

Comment 6

7 years ago
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/430dddaaf423
Call updateTabBarForActiveGroup so that Group is correctly set for this.
Comment on attachment 459972 [details] [diff] [review]
v1

Looks good except for this line:

Utils.timeout(Groups.updateTabBarForActiveGroup, 400);

"this" won't be set up properly.
Attachment #459972 - Flags: review-
Attachment #459972 - Flags: feedback-
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

7 years ago
See comment 6.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Blocks: 582116
(Assignee)

Updated

7 years ago
Blocks: 582872
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Component: TabCandy → TabCandy
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Keywords: dev-doc-needed
Documented here:

https://developer.mozilla.org/en/XUL/Method/showOnlyTheseTabs
https://developer.mozilla.org/en/XUL/Method/showAllTabs

Added to the list of methods on tabbrowser here:

https://developer.mozilla.org/en/XUL/tabbrowser

Linked from Firefox 4 for developers.
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Comment 11

7 years ago
sheppy, sorry for the confusion, but this bug originally landed as part of the tabcandy-central branch, and the code that landed in m-c is in bug 582116 where there ended up not being a showAllTabs.
Removed showAllTabs from the docs; thanks!
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.