Closed Bug 580878 Opened 12 years ago Closed 12 years ago
Remove/reduce tabcandy-specific Utility code which rewraps native interfaces
As per Gavin's recommendation on #574217, we should use less or no utility functions which rewrap native Firefox interfaces. Marked P1 because it could help with getting on trunk. I'm of the belief that utility functions aren't always bad... so to get this party started, I propose a rule of thumb that if a helper/Utils function isn't used in more than X places in the tabcandy code, it should be thrown out and that logic be placed inline where the function is (was) used. I will begin the discussion by proposing X = 3. Discuss! (And yes there's also #574219 but the scope of that ticket is unclear to me so I thought I'd create another, more focused one.)
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/2df86a3068c9 http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/25fb05ea9878 I've also done some simplification/cleanup of the geometry-related functions in utils.js as bug 581143.
All descendant bugs are resolved fixed now, so I'm closing this. Go team!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy. Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.