580878 - Remove/reduce tabcandy-specific Utility code which rewraps native interfaces

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P1)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

As per Gavin's recommendation on #574217, we should use less or no utility functions which rewrap native Firefox interfaces. Marked P1 because it could help with getting on trunk.

I'm of the belief that utility functions aren't always bad... so to get this party started, I propose a rule of thumb that if a helper/Utils function isn't used in more than X places in the tabcandy code, it should be thrown out and that logic be placed inline where the function is (was) used.

I will begin the discussion by proposing X = 3. Discuss!

(And yes there's also #574219 but the scope of that ticket is unclear to me so I thought I'd create another, more focused one.)

Comment 1

[Ed Lee :Mardak]

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/2df86a3068c9

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/2df86a3068c9

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/25fb05ea9878

I've also done some simplification/cleanup of the geometry-related functions in utils.js as bug 581143.

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

All descendant bugs are resolved fixed now, so I'm closing this. Go team!

Comment 5

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".