582371 - Enable VKB in Maemo 6 / Meego Qt Version

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jeremias Bosch (:jbos)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100317 SUSE/3.5.9-0.1.1 Firefox/3.5.9
Build Identifier: 

As a user i want to see and use the meego vkb in the qt build.

Reproducible: Always

Comment 1

[Jeremias Bosch (:jbos)]

Attachment: patch to add qt meego vkb

Comment 2

[Jeremias Bosch (:jbos)]

Attachment: patch to add qt meego/maemo6 vkb

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 460657 [details] [diff] [review]
patch to add qt meego/maemo6 vkb

stealing from mfinkle.

Comment 4

[Doug Turner (:dougt)]

what is gFailedOpenKeyboard about?

Comment 5

[Jeremias Bosch (:jbos)]

The interaction in meego/maemo6 between browser / vkb / windowmanager is really fragile and this is there to cover the most common failure case and make it more robust. The failure covered by this ends up in:
 - Flickering,
 - Disorder of VKB and Browser
 - Invisible (but interactive) VKB
 - Crash of the browser

It is caused by activating the vkb from within a non active application. This was i.e. the case when the awesomebar was activated during startup.

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 460657 [details] [diff] [review]
patch to add qt meego/maemo6 vkb

Drop the #ifdefs.  It doesn't sound like we need them.

Where we are using known values instead of #include from some SDK, can we add a comment?

Comment on why you need:

+static bool gFailedOpenKeyboard = false;

Maybe it should be something like:

/* In case we could not open the keyboard, we will try again when the focus event is sent.  This can happen if the keyboard is asked for before the window is focused. */

Comment 7

[Steffen Imhof]

Attachment: Review comments addressed

This is an updated version of the patch that should address all review issues.
Take note that is now also put on top of the recently rebased MApplication patch in bug 583179.

Comment 8

[Steffen Imhof]

Attachment: Updated to apply on the latest version of 583179

The patch for bug 583179 changed a bit, so this one is now updated to apply on top of the latest version.

Comment 9

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/a73ba51c5b1d

Comment 10

[Catalin Suciu [:csuciu]]

Verified fixed on:
Mozilla/5.0 (Maemo;Linux armv7l;rv:7.0)Gecko/20110908
Firefox/7.0 Fennec/7.0