Closed Bug 583103 Opened 15 years ago Closed 15 years ago

Inline review editing

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
5.11.9

People

(Reporter: jbalogh, Assigned: potch)

References

Details

(Whiteboard: [z])

The edit url is /addon/:addon/reviews/:review/edit. It expects a POST with normal form data and returns the right HTTP status code. If there are form errors it will return a 400 json response like {'field': ['error message']}. Submitting a review without a rating triggers an error. It expects (body, title, rating) for reviews and (body, title) for replies. The current forms are generated from reviews/forms.py.
The edit function is at http://github.com/jbalogh/zamboni/commit/f4dd63e#L4R154 if that makes any sense to you.
Priority: -- → P2
Blocks: EditMultipleReviews
Target Milestone: 5.11.8 → 5.11.9
http://github.com/jbalogh/zamboni/commit/9fac297
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Depends on: 592466
Bug 592454 and bug 592466 are not making the 5.11.9 cut, so I'm moving them out on their own; fare well! Verified FIXED.
Status: RESOLVED → VERIFIED
No longer depends on: 592454, 592466
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.