586712 - Lighten tabOnFocus (and rename it)

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Ian Gilman [:iangilman]]

From dolske's review of bug 574217: 

> >+  // Called when the user switches from one tab to another outside of the TabView UI.
> >+  tabOnFocus: function(tab) {
> 
> This seems like a surprising amount of code to be running on each tab selection
> change... Is there an opportunity for an early return / skipping work when not
> needed (eg, set a dirty bit and handle it later)?
> 
> [Nit: call this tabOnSelect, because it really doesn't have anything to do with
> _focus_.]

Some of this work we definitely need to do every time. In particular, the "zoom prep" is the only way we've found to get a smooth zoom out. Some of it can probably be deferred if we're not in the Tab Candy UI.

Comment 1

[Aza Raskin [:aza]]

Some of this may be helped when we get hardware acceleration. Of course, it also might not.

Comment 2

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 4

[Raymond Lee [:raymondlee]]

Comment on attachment 466568 [details] [diff] [review]
v1

I found a bug in this patch.  Will upload another one later

Comment 5

[Raymond Lee [:raymondlee]]

Attachment: v1

I've renamed the method and everything inside the method is necessary. GroupItems.updateActiveGroupItemAndTabBar(newItem) is for setting the active group item and updating the tab bar because zooming into a tab, using key combination, the switch to tab feature in the awesome bar might select a tab in other group.  Other code is for setting zoom in preparation.

Comment 6

[Ian Gilman [:iangilman]]

Comment on attachment 466635 [details] [diff] [review]
v1

Looks good to me.

Comment 7

[Raymond Lee [:raymondlee]]

Attachment: v1 [r=dolske a=dolske]

Check-in needed

Comment 8

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/rev/b4b1ba3c2651