587039 - Rename View > TabView And All Instances of Tab Sets to "Group my tabs..."

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[(no longer active)]

We're calling tabcandy "Tab Sets", and I think the View menu entry should reflect that.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Martijn Wargers (dead)]

So Tabcandy==Tab Sets?
Are the tab sets I see in Tabcandy tab sets, then? Or are they called tab groups?

Comment 3

[Ed Lee :Mardak]

Aza said to hold off on giving it an official user facing name and just describe the functionality. "Organize your tab groups" instead of something like "Open Tab Sets"

Comment 4

[(no longer active)]

I think we need to make a call here before beta4.

Comment 5

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".

Comment 6

[Aza Raskin [:aza]]

For b4 we are staying away from in-product branding (so yes, that does mean I'll have to update the video, but that can happen outside of the Firefox beta release schedule). Marketing is helping us come up with a name but that will take until early next week (after string freeze). Thus, the menu should say "Organize your tabs..."

The tooltip should say the same thing for hovering on the Tab Candy button. (With the os-apropos keyboard shortcut).

Comment 7

[Aza Raskin [:aza]]

Mayumi suggests "Group your tabs..." which is more direct and shorter. Let's go with that.

Comment 8

[Aza Raskin [:aza]]

Final iteration "Group my tabs..."

Comment 9

[(no longer active)]

Attachment: Patch (v2)

This should land today if it's going to make beta4.

Comment 10

[(no longer active)]

Attachment: Patch (v3)

With changes to the title of the tab candy window.

Comment 11

[Ian Gilman [:iangilman]]

Attachment: Patch v4

Comment 12

[Justin Dolske [:Dolske]]

Comment on attachment 465897 [details] [diff] [review]
Patch v4

>-<!ENTITY tabViewButton.label          "Tab Sets">
>-<!ENTITY tabViewButton.tooltip        "Open a visual tab interface">
>+<!ENTITY tabViewButton2.label         "Group Your Tabsâ¦">
>+<!ENTITY tabViewButton2.tooltip       "Group Your Tabsâ¦">

Nit: the label should be a smaller string -- "Tab Groups" -- and the tooltip shouldn't have the trailing ellipsis.

r+ with that.

Comment 13

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/rev/3a7615f9b0d3

Comment 14

[Francesco Lodolo [:flod]]

-tabView.title=%S Tab Sets
+tabView2.title=%S - Group Your Tabs

Care to explain what is that variable? Please add useful localization comments when you commit new strings.

Comment 15

[Axel Hecht [:Pike]]

Also, "Group Your Tabs" can have a much better name than tabView2, using numeric increments is generally the least good option.

Comment 16

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/rev/41bdff98187a

Comment 17

[Ian Gilman [:iangilman]]

(In reply to comment #14)
> -tabView.title=%S Tab Sets
> +tabView2.title=%S - Group Your Tabs
> 
> Care to explain what is that variable? Please add useful localization comments
> when you commit new strings.

This is for the window title while the Tab Candy UI is up. The %s becomes the application name, so it'll be "Firefox - Group Your Tabs".

Comment 18

[Ian Gilman [:iangilman]]

(In reply to comment #15)
> Also, "Group Your Tabs" can have a much better name than tabView2, using
> numeric increments is generally the least good option.

I was told we need to add a number to indicate to the localization team that it was a substantive change (rather than just fixing a typo). Is this not true? Is there a better way?

Comment 19

[Axel Hecht [:Pike]]

Ian, mind dropping me a mail who said so, might be good to do some focused messaging there.

In general, string names should be "good variable names" in a "good programming" sense, and foo2 is obviously not. Sometimes we're between a rock and a hard place, where there's no good new name, in which case, rev'ing the entity name with a number is the last resort. But in this case "groupYourTabs" would have been a much better name than tabView, or tabView2.

Comment 20

[Ian Gilman [:iangilman]]

(In reply to comment #19)
> Ian, mind dropping me a mail who said so, might be good to do some focused
> messaging there.
> 
> In general, string names should be "good variable names" in a "good
> programming" sense, and foo2 is obviously not. Sometimes we're between a rock
> and a hard place, where there's no good new name, in which case, rev'ing the
> entity name with a number is the last resort. But in this case "groupYourTabs"
> would have been a much better name than tabView, or tabView2.

I actually don't remember who it was. 

Anyway, I agree that it did not have a good name to begin with. If it did have an ideal name, however, then I should add a number to it if the phrase needs retranslating but the meaning of the variable hasn't changed? Seems wrong to change the variable name to something substandard just to avoid adding a number.