Closed
Bug 588689
Opened 14 years ago
Closed 9 years ago
Add access to site preferences from the site identity block
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: faaborg, Unassigned)
References
Details
Attachments
(1 file)
1.61 KB,
patch
|
Details | Diff | Splinter Review |
Once site preferences lands, we should hook up access from the site identity block.
Mockup: https://bugzilla.mozilla.org/attachment.cgi?id=467310
Comment 1•14 years ago
|
||
Small patch that replaces the "More information..." -> More Info panel call to cause a click on "More information..." to open up Site Preferences with the site selected.
This does not handle the UI change yet.
Assignee: nobody → mmulani
Status: NEW → ASSIGNED
Comment 2•14 years ago
|
||
Comment on attachment 467430 [details] [diff] [review]
Initial patch.
>diff --git a/browser/base/content/utilityOverlay.js b/browser/base/content/utilityOverlay.js
>+function openWebSitePreferences() {
>+ let host = makeURI(window.content.document.location, null, null).host;
This will fail for non-nsIStandardURL nsIURIs (e.g. about: URIs). Just use content.document.location.hostname (it's safe since http://hg.mozilla.org/mozilla-central/rev/fc754baf4c59 ).
Updated•14 years ago
|
Comment 3•14 years ago
|
||
(In reply to comment #2)
> This will fail for non-nsIStandardURL nsIURIs (e.g. about: URIs). Just use
> content.document.location.hostname (it's safe since
> http://hg.mozilla.org/mozilla-central/rev/fc754baf4c59 ).
Oh sweet, I was looking for a way to do this nicely.
Thanks.
Comment 4•14 years ago
|
||
I'll take over this bug, since I'm working on bug 573176.
Assignee: mars.martian+bugmail → margaret.leibovic
Comment 5•13 years ago
|
||
I'm not actively working on this, so un-assigning myself. Also, this needs some UX direction before it can go forward.
Comment 6•12 years ago
|
||
Chrome added something like this in the meantime: You can see and change *any* site-specific pref when clicking the identity icon.
The mockup in comment 0 is pretty cool too.
Can we have a combination of both? I. e. one can easily access and change the site specific prefs from the Site Identity doorhanger panel (e. g. "hidden" behind a tab like Chrome does it or an accordion) AND highlight specific prefs (as proposed by the mockup, plus possibly in the complete list) the website requested (e. g. the last 2 requested prefs).
Comment 7•12 years ago
|
||
Sorry, I missunderstood the scope of this bug.
Do you think a chrome-style site specific pref pane is worth considering?
Updated•11 years ago
|
Assignee: limi → nobody
Comment 8•9 years ago
|
||
about:permissions has been removed in bug 933917.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•