769472 - Remove "View Page Info" from the context menu

Status: RESOLVED DUPLICATE of bug 1692553

(Firefox :: Menus, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

We should remove the "View Page Info" from the context menu. There is already two other places to access the Page Info dialog (from the site identity panel as well as the Tools menu).

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Matthew N. [:MattN]]

(In reply to Jared Wein [:jaws] from comment #0)
> There is already two other places to access the Page Info dialog

* site identity panel

The context around this button leads one to believe the dialog only contains security information. (It also open the dialog to the security tab).

* Tools menu

Only visible by default on XP and OS X and doesn't let you view info for subframes.

I think removing the entry from the tools menu would be more desirable for the above reasons.

Comment 3

[u428464]

FWIW Page info is going away with Australis redesign(maybe I've misunderstood)or it's gonna be redesign to connect better with about:permissions.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

There has been talk about merging the Permissions portion of Page Info with about:permissions once about:permissions has a visible entry point, but until then there is no plan to make changes to the Permissions portion of Page Info (or any other part of Page Info).

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Update tests

I'll fold the two patches together when I land.

Comment 6

[Frank Yan (:fryn)]

Comment on attachment 637734 [details] [diff] [review]
Patch

https://mxr.mozilla.org/mozilla-central/source/browser/base/content/nsContextMenu.js#208

You missed this line.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug v2

Removed line, carrying forward ui-r+ from fang.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 638025 [details] [diff] [review]
Patch for bug v2

(In reply to Matthew N. [:MattN] from comment #2)
> (In reply to Jared Wein [:jaws] from comment #0)
> > There is already two other places to access the Page Info dialog
> 
> * site identity panel
> 
> The context around this button leads one to believe the dialog only contains
> security information. (It also open the dialog to the security tab).
> 
> * Tools menu
> 
> Only visible by default on XP and OS X and doesn't let you view info for
> subframes.

Right, this situation seems insufficient. One way to address this might be to add Page Info to both Web Developer menus, such that the location bar covers the security stuff and Web Developer covers the General and Media tabs. However, this still leaves the question of what to do about the Permissions tab and sub frames.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Dão Gottwald [:dao] from comment #8)
> Comment on attachment 638025 [details] [diff] [review]
> Patch for bug v2
> 
> (In reply to Matthew N. [:MattN] from comment #2)
> > (In reply to Jared Wein [:jaws] from comment #0)
> > > There is already two other places to access the Page Info dialog
> > 
> > * site identity panel
> > 
> > The context around this button leads one to believe the dialog only contains
> > security information. (It also open the dialog to the security tab).
> > 
> > * Tools menu
> > 
> > Only visible by default on XP and OS X and doesn't let you view info for
> > subframes.
> 
> Right, this situation seems insufficient. One way to address this might be
> to add Page Info to both Web Developer menus, such that the location bar
> covers the security stuff and Web Developer covers the General and Media
> tabs. However, this still leaves the question of what to do about the
> Permissions tab and sub frames.

The context menu item always only opened the Page Info for the top frame. See the line of code here:
>- viewInfo: function() {		
>-   BrowserPageInfo(this.target.ownerDocument.defaultView.top.document);		
>- },

I think there are two issues to address here:
1) We don't need a menuitem to access each tab within the Page Info dialog, the same way we don't have menuitems to access each tab within the Preferences.

2) I asked for ui-review on this patch to get signoff from the UX team as to the desired interactions here. The issues brought up in comment #8 and comment #2 are based on the interactions, not on the level of code quality. For questions like these, we should be deferring to the UX team and not overriding their judgements.

Comment 10

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] from comment #9)
> The context menu item always only opened the Page Info for the top frame.
> See the line of code here:
> >- viewInfo: function() {		
> >-   BrowserPageInfo(this.target.ownerDocument.defaultView.top.document);		
> >- },

Interesting, so your patch leaves "View Frame Info" intact?

> 1) We don't need a menuitem to access each tab within the Page Info dialog,
> the same way we don't have menuitems to access each tab within the
> Preferences.

We have a generic entry point for Preferences. We don't really have that for Page Info, as comment 2 pointed out.

The UX team isn't an oracle spitting out absolute truths. If comment 2 has been considered, please provide the reasoning in the bug.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Dão Gottwald [:dao] from comment #10)
> Interesting, so your patch leaves "View Frame Info" intact?

Yes, because there is no other entry point for that information. I'll defer to someone from the UX team to respond to the other question.

Comment 12

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Is there any bug for removing also "View Page Source"?
or we won't be removing it?

Comment 13

[Zhenshuo Fang (:fang) - Firefox UX Team]

(In reply to Matthew N. [:MattN] from comment #2)
> * site identity panel
> 
> The context around this button leads one to believe the dialog only contains
> security information. (It also open the dialog to the security tab).
> 
> * Tools menu
> 
> Only visible by default on XP and OS X and doesn't let you view info for
> subframes.
> 
> I think removing the entry from the tools menu would be more desirable for
> the above reasons.

(In reply to Dão Gottwald [:dao] from comment #10)
>
> We have a generic entry point for Preferences. We don't really have that for
> Page Info, as comment 2 pointed out.
> 
> The UX team isn't an oracle spitting out absolute truths. If comment 2 has
> been considered, please provide the reasoning in the bug.

Even we have three entry points for "view page info", the identity panel should be the place that the user go to to find page-specific information. The current design does emphasis a lot on security information, but user can still access general information from there. And we already have bugs tracking the redesign of identity panel. see bug588613, bug 588685, bug 588689. 

IMO removing the link from context menu help simplify the UI, and it doesn't take away the ability for users to access the information (we should even educate user to go to identity panel after we have a better design for larry) Besides, we have heatmap data showing that very few users actually use "view page info" in the context menu.

For "Web Developers" menu, the UI is already quite busy there. I'll avoid adding too many links in the sub-menu unless it's really relevant to webDev users.

Comment 14

[Dão Gottwald [:dao]]

(In reply to Zhenshuo Fang (:fang) - Firefox UX Team from comment #13)
> Even we have three entry points for "view page info", the identity panel
> should be the place that the user go to to find page-specific information.
> The current design does emphasis a lot on security information, but user can
> still access general information from there.

Sure, but it's not clear that you're going to find that stuff there in the first place.

> And we already have bugs
> tracking the redesign of identity panel. see bug588613, bug 588685, bug
> 588689.

These bugs are two years old and apparently stalled, so just pointing to their existence doesn't quite satisfy me. Reviving bug 588689 and fixing it by opening Page Info's Permissions tab rather than about:permissions might be a realistic short-term solution, though.

> For "Web Developers" menu, the UI is already quite busy there. I'll avoid
> adding too many links in the sub-menu unless it's really relevant to webDev
> users.

The General and Media tabs are relevant, I think, and don't seem to be covered by other web dev tools.

Comment 15

[jscher2000]

Removed from the context menu in Fx88 by bug 1692553. Sorry to see it go.

Comment 16

[:Gijs (he/him)]

Fixed in bug 1692553.