589261 - Tab changes group if asking for input at startup and doesn't change back

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Robert Haas [:scenor]]

User-Agent:       Mozilla/5.0 (X11; Linux i686; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre
Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre

If some site wants input (javascript prompt/alert/..., passwords (also FTP), etc.) when starting firefox, it changes to the active tab group and does only change back when opening TabCandy but not by itself.

Reproducible: Always

Steps to Reproduce:
1.Open site asking for input when opening
2.Change group
3.Restart Firefox with Tab restoring activated
Actual Results:  
Group active when closing is active again, but the tab asking for input changes to this group, and after giving input, doesn't change back till TabCandy is opened again.

Expected Results:  
Firefox should either change to the group where a Tab wants input (like when a site asks for input when opened earlier (f.ex. by Javascript Timeout) and leave all the Tabs in the groups where they belong to or temporarily change the Tab's group and change it back after input has been given.

Comment 2

[Dave Miller [:justdave]]

confirming based on duplicate

Comment 3

[Aza Raskin [:aza]]

Seems like a frustrating edge-case that will bite people. Not as important as, say, performance but still worth tackling.

Comment 4

[Raymond Lee [:raymondlee]]

Since the Panorama isn't activated, we are not able to show the appropriate tabs in the selected group.  May be we can have code to check whether any dialog appears after page load.  If yes and Panorama isn't activated, activate Panorama and show the appropriate tabs in the selected group.  The tricky part is to how to detect a dialog is opened by the page.

Comment 5

[Ian Gilman [:iangilman]]

(In reply to comment #4)
> Since the Panorama isn't activated, we are not able to show the appropriate
> tabs in the selected group.  May be we can have code to check whether any
> dialog appears after page load.  If yes and Panorama isn't activated, activate
> Panorama and show the appropriate tabs in the selected group.  The tricky part
> is to how to detect a dialog is opened by the page.

Better yet, we should have code detect whether a hidden tab becomes unhidden, and then wake up Panorama; this should handle this bug, plus a number of related issues.

Comment 6

[Raymond Lee [:raymondlee]]

Patch for bug 589324 would also fix this.

Comment 7

[Raymond Lee [:raymondlee]]

Fixed by the patch for bug 589324