590378 - Hide menu-bar persona drawing when in Panorama

Status: RESOLVED INVALID

(Firefox Graveyard :: Panorama, defect, P3)

Description

[matthias koplenig [:metasieben]]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre

since in panorama only the top-bar is visible(mac only?), the lightweight-theme looks rather strange, therefore hide it, when entering panorama, on exit show it again.

Reproducible: Always

Comment 1

[JackDMF]

Additional information:
On Windows XP SP3 only the Titlebar is visible, and the new firefox button on the left and the persona does not change anything there (no strange look).

Comment 2

[matthias koplenig [:metasieben]]

afaik. it's not possible to draw in the titlebar in XP. so this might only be an osx-issue.

added a partial-screenshot to illustrate the point.

Comment 3

[matthias koplenig [:metasieben]]

Attachment: partial-screenshot

Comment 4

[JackDMF]

Ok, will try that with windows 7 and post results here.

Comment 5

[JackDMF]

On Windows 7 there is the same issue, though i do not think that it's ugly.

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

See also: bug 593388.

Comment 7

[Anant Narayanan [:anant]]

Attachment: Disable persona when in panorama

This patch disables a persona (if selected) when switching to panorama mode, and also setting it back to what it was before when the user exits.

The reason we use the LightweightThemeManager instead of just saying:

documentElement.removeAttribute("drawintitlebar");

is because: a) that will not work on Windows 7, and b) we want to be future-proof and it's best not to make any assumptions about how the theme manager paints a persona on the window.

Comment 8

[Ian Gilman [:iangilman]]

Comment on attachment 487744 [details] [diff] [review]
Disable persona when in panorama

Looks good to me!

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 487744 [details] [diff] [review]
Disable persona when in panorama

If there are multiple Firefox windows, this will affect all of them. Also if you exit Firefox during that time, this looks like the theme won't be reactivated.

Comment 10

[Kevin Hanes]

Continuing to reassign all Anant's bugs to Raymond.

Comment 11

[Michael Yoshitaka Erlewine [:mitcho]]

Moving to beta 10, but unless someone takes this up soon, we most likely will punt.

Comment 12

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #11)
> Moving to beta 10, but unless someone takes this up soon, we most likely will
> punt.

Er, beta 11, is what I meant.

Comment 13

[Michael Yoshitaka Erlewine [:mitcho]]

Alex, Stephen: should we be continuing on this bug (hiding the menu bar persona drawing on Mac) or instead should we pursue some persona support for Panorama as we did for Windows in bug 591652?

Comment 14

[Michael Yoshitaka Erlewine [:mitcho]]

[bugspam: mitcho's late-night betaN triage; feel free to comment or reverse]

Comment 15

[Alex Faaborg [:faaborg] (Firefox UX)]

>or instead should we pursue some persona support for Panorama
>as we did for Windows in bug 591652?

yeah, I think we should try the windows approach here, and also push on getting personas updated to be as full screen as possible.

Comment 16

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #15)
> >or instead should we pursue some persona support for Panorama
> >as we did for Windows in bug 591652?
> 
> yeah, I think we should try the windows approach here, and also push on getting
> personas updated to be as full screen as possible.

The Windows fix in bug 591652 assumes some constant height, if I recall. It won't just be a matter of getting people to make their panoramas full screen. Some thought will have to go into this, imho.

Going to file a couple follow ups and close this bug.

Comment 17

[Michael Yoshitaka Erlewine [:mitcho]]

Filed followups: bug 593388, bug 633392.