592548 - Build the author/license/policy page

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

Mockups: 
http://people.mozilla.com/~chowse/drop/amo/devtools/v2/Addon_03_Authors.png

This page combines authors, licenses, and policies.  An add-on must have at least 1 listed author.

Backend:  This is pretty much displaying information we already have.  Other licenses are stored in the `licenses` table.  That schema is not the best.

Front end:  The form is displayed by default.  It should submit to the API.  I imagine there will be some questions about API and help text - when you get to that point, just ask.

Comment 1

[Wil Clouser [:clouserw]]

Licenses consist of some predefined licenses in apps/amo/__init__ and custom ones in the db.  It's an awkward mix, and I'm happy to talk about alternatives.

Comment 2

[Chris Howse [:chowse]]

Annotated mocks and workflows are now available:

http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/00_common.png
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/04_authors_license.png

http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon.pdf
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/interaction.pdf

Comment 4

[Jeff Balogh (:jbalogh)]

What's the ordering & text of the author role dropdown?  These are the choices:

AUTHOR_CHOICES = {
    AUTHOR_ROLE_NONE: 'None',
    AUTHOR_ROLE_VIEWER: 'Viewer',
    AUTHOR_ROLE_DEV: 'Developer',
    AUTHOR_ROLE_OWNER: 'Owner',
    AUTHOR_ROLE_ADMIN: 'Admin',
    AUTHOR_ROLE_ADMINOWNER: 'Admin & Owner',
}

I don't think ROLE_NONE should show up in this form.

Comment 5

[Jeff Balogh (:jbalogh)]

What are the rules for the roles?  What does each give you access to?  The answer probably deserves a separate bug.

Comment 6

[Jeff Balogh (:jbalogh)]

(In reply to comment #5)
> What are the rules for the roles?  What does each give you access to?  The
> answer probably deserves a separate bug.

Now bug 600442.

What's the title & breadcrumb of this page?

Comment 7

[Justin Scott [:fligtar]]

Breadcrumb should be:
Add-ons for Firefox > Developer Hub > My Add-ons > Password Exporter > Manage Authors & License

(let's try that and if it's too long we can trim it down)

Comment 8

[Chris Howse [:chowse]]

(In reply to comment #7)
> Breadcrumb should be:
> Add-ons for Firefox > Developer Hub > My Add-ons > Password Exporter > Manage
> Authors & License

I'd recommend losing the last part ("Manage Authors & License"). All the pages for managing an existing add-on (Edit Details, Manage Authors, etc.) are on the same hierarchical level, and use the nav sidebar to indicate which sub-page is being viewed. If the sub-pages have crumbs, there isn't a mock-up right now that corresponds to "My Add-ons > Password Exporter".

Comment 9

[Justin Scott [:fligtar]]

I didn't realize we don't have a landing page for managing individual add-ons. That will probably be a problem later on. But I guess we can remove the last part now.

Comment 10

[Chris Howse [:chowse]]

(In reply to comment #9)
> I didn't realize we don't have a landing page for managing individual add-ons.
> That will probably be a problem later on.

The "Edit Listing" page serves as the default if the user doesn't explicitly indicate a different sub-page (for example, if they click on an add-on's title in the "My Add-ons" page).

Comment 11

[Justin Scott [:fligtar]]

(In reply to comment #10)
> (In reply to comment #9)
> > I didn't realize we don't have a landing page for managing individual add-ons.
> > That will probably be a problem later on.
> 
> The "Edit Listing" page serves as the default if the user doesn't explicitly
> indicate a different sub-page (for example, if they click on an add-on's title
> in the "My Add-ons" page).

We just determined this independently! If only you sat closer to us.

Comment 12

[Jeff Balogh (:jbalogh)]

QA:

* Only admins/owners should be able to change things on the page
* We need at least one owner
* We need at least one listed author

Comment 13

[Jeff Balogh (:jbalogh)]

Added the author functionality in http://github.com/jbalogh/zamboni/commit/d1ebcf0.

Comment 14

[Jeff Balogh (:jbalogh)]

* The license form edits the latest version's license, going by -version_number.
* If there's no version available that block will say ____.
* There's user messaging about what version they're editing.  It says ____.

Comment 15

[Justin Scott [:fligtar]]

(In reply to comment #14)
> * If there's no version available that block will say ____.
<a>Upload a version</a> to select a license.

> * There's user messaging about what version they're editing.  It says ____.
Changing the license will only apply to the latest version of your add-on (%version_number%).

Comment 16

[Jeff Balogh (:jbalogh)]

Merged in http://github.com/jbalogh/zamboni/commit/08fa1de.

potch: Here's a hideous page that looks nothing like the mocks.  But it's functional!  I didn't add the strings from comment 15 either.

QA: You can try to break it at https://preview.addons.mozilla.org/z/en-US/developers/addon/2848/ownership.

Developers: Run ./manage.py upgrade_licenses after doing migrations to get your database into shape.

Comment 17

[Chris Howse [:chowse]]

Icons for dragging & dropping authors:

http://people.mozilla.com/~chowse/drop/amo/icons/icon-draggable.png
http://people.mozilla.com/~chowse/drop/amo/icons/cursor-openhand.png
http://people.mozilla.com/~chowse/drop/amo/icons/cursor-closedhand.png

Comment 18

[Potch [:potch]]

BOOM http://github.com/jbalogh/zamboni/commit/d545531

Comment 19

[Gervase Markham [:gerv]]

Can the license page please at least have an option for the standard Mozilla licensing scheme (MPL/LGPL/GPL triple)? I'd suspect it's a common licensing model for addons ("same license as Mozilla"), and they probably incorrectly just pick "MPL".

Gerv

Comment 20

[Gervase Markham [:gerv]]

OK, I filed bug 605423.

Gerv