593139 - Tabcandy's keyboard toggling event should balk on richlistbox (like listbox)

Status: RESOLVED INVALID

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Adam]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100729 Iceweasel/3.6.7 (like Firefox/3.6.7)
Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b4) Gecko/20100818 Firefox/4.0b4

I cannot have my richlistbox's keypress event catch ctrl+space for keyboard accessibility.  

At http://hg.mozilla.org/mozilla-central/file/ba1849f86ade/browser/base/content/browser-tabview.js#l213 I can see that Tabview lets it through for tree elements and listbox elements, but not for richlistbox.  

Reproducible: Always

Steps to Reproduce:
1. Create a richlistbox with seltype="multiple" and keypress event handler.
2. Try to multi-select with ctrl+space.

Actual Results:  
Tab candy opens.  

Expected Results:  
The handler catches the event and does its job.  

The simplest fix would simply be adding the "richlistbox" case either before or after the "listbox" case, and letting the same case hold.  Since the author using a multi-select richlistbox would have implemented the handler, this should be acceptable.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Note: There's a similar issue (can't find it now) requesting that we not allow going into Panorama via the key combo in input boxes.

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

Bug 591190 is the bug I was referring to.

Comment 3

[Adam]

Bug 592183 makes this moot.  Thanks.