591190 - panorama keyboard shortcut should not trigger when in textfields

Status: RESOLVED INVALID

(Firefox Graveyard :: Panorama, defect, P2)

Description

[philippe (part-time)]

The Tab Candy keyboard shortcut (option-space) should NOT open Tab Candy when the focus is in an input field

STR
1. start typing in an input field / textarea
2. press option space (standard OS X key combo for a non-breaking space)
3. %%6$## </swear>

AR. tab candy opens…
ER. Input a non-breaking space

(filed per bug 587505 comment 5)

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: v1

Comment 2

[Alice0775 White]

And also see Bug 591190,
Panorama should ignore keypress of ENTER(DOM_VK_RETURN) while IME composition .

Comment 3

[Alice0775 White]

Oops , Sorry, in comment #2
s/Bug 591190/Bug 587243/

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 470310 [details] [diff] [review]
v1

getting first-review from ian.

Comment 5

[Ian Gilman [:iangilman]]

Comment on attachment 470310 [details] [diff] [review]
v1

Looks good.  Adding Aza for UI.

Comment 6

[Aza Raskin [:aza]]

I'm worried that this sets up a modality... you are used to using option-space to invoke Panorama and then all of a sudden it stops working. I doubt it will be obvious that it is because you are in a textarea that Panorama appears broken.

To put it another way, it is very frustrating that Flash eats key presses. How many times have you become annoyed that you can't use the standard keyboard shortcut for "Back" because Flash gobbles it up? Would you be able to use the keyboard shortcut while writing in Gmail or any other email client? During the middle of leaving a comment on Bugzilla?

Comment 7

[Dietrich Ayala (:dietrich)]

Dueling frustrations.

The root of the problem is that the current keyboard shortcut is an extremely common one (as evidenced by the volume of bugs filed about it). We could ditch this patch in favor of fixing fixing bug 587505 and/or changing the default shortcut.

Comment 8

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #7)
> The root of the problem is that the current keyboard shortcut is an extremely
> common one (as evidenced by the volume of bugs filed about it). We could ditch
> this patch in favor of fixing fixing bug 587505 and/or changing the default
> shortcut.

Agreed. Fixing bug 587505 is one thing, but having a smarter default is also important. As discussed in bug 592183, perhaps something command-y like command/alt-[...] would be better and less likely to conflict with OS/IMEs.

Comment 10

[Michael Yoshitaka Erlewine [:mitcho]]

See also bug 593139 which is for this bug, but for xul:richlistbox

Comment 11

[jrblier]

Sorry for creating a duplicate earlier [bug 593139].

This is a nasty bug!

TabCandy should not eat option-space, since this is the only way to enter a non-breaking space.

Either tell us how to disable tab-candy, or how to change the shortcut.

Comment 12

[Raymond Lee [:raymondlee]]

This won't be valid when bug 592183 is fixed.

Comment 13

[Dietrich Ayala (:dietrich)]

(In reply to comment #12)
> This won't be valid when bug 592183 is fixed.

That bug summary sounds like it's just a shortcut change. Does that patch also fix this problem?

Comment 14

[Raymond Lee [:raymondlee]]

(In reply to comment #13)
> That bug summary sounds like it's just a shortcut change. Does that patch also
> fix this problem?

The reason we have this bug is that user wants to input a non-breaking space into textfields but  alt+space is used to toggle the panorama UI.  Now, we are changing it to  ccmd/clt + e which wouldn't affect any input characters so this won't be valid when the patch for bug 59183 lands IMO.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

I think this is now INVALID given the fix for bug 592183 (shortcut is now Cmd+E, which doesn't conflict with any common input field shortcuts).

Comment 16

[Kevin Hanes]

Bug invalid, removing blocking