594976 - [gfxInfo] Adapter description, device ID and vendor ID are null or empty for some graphic cards under Windows 2000/XP

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Barry Marshall]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b6pre) Gecko/20100909 Firefox/4.0b6pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b6pre) Gecko/20100909 Firefox/4.0b6pre

My usual Thinkpad T61 under Windows XP SP3.

about:config doesn't have any information about my graphics adapter, but Grafx Bot can tell me something about it.  Why the difference?

Reproducible: Always

Steps to Reproduce:
1.Load Trunk with Grafx Bot 0.1.23
2.Start Grafx Bot and go to System Info
3.Open another window with about:support
4.Compare reported information
Actual Results:  
about:support doesn't have the same info as Grafx Bot

Expected Results:  
Information should be the same.

Built from http://hg.mozilla.org/mozilla-central/rev/8e0fce7d5b49

Comment 1

[Barry Marshall]

Attachment: Screenshot

Comment 2

[Barry Marshall]

Sorry, that should obviously be "about:support" in my second paragraph there.

Comment 3

[Barry Marshall]

In the time since this bug was filed, Gecko/20100910 Firefox/4.0b6pre is giving me a solid black window interior regardless of what I try to do (resize, cover, new window, etc.), so hopefully this information will still be presented properly if layers.accelerate-all is set to false.

Comment 4

[Barry Marshall]

This won't be testable unless we can see what we're doing, so we'll need Bug 593678 fixed.

Comment 6

[Stebs]

Attachment: GPU-Z Screenshot of GMA950

Comment 7

[Stebs]

Have exactly same problem with an GMA 950 (Intel 945GME) 0x27AE
This is with a nightly after the new Intel blacklist matrix patch.
Grafxbot got it right:
http://brasstacks.mozilla.com/resultserv/data/results/5b054ed8-17f4-408f-97db-6d25807b62b6

GPU-Z screenshot in attachment above.

Comment 8

[Tetsuro Kato (tete)]

Attachment: case-insensitive comparison for DeviceKey of DISPLAY_DEVICE

Because wcsncmp() performs a case-sensitive comparison, initialization routine for GfxInfo may not be executed depending on value of DeviceKey member of DISPLAY_DEVICE structure.

On my system (RADEON 9600) under Windows 2000, DeviceKey of DISPLAY_DEVICE gets the following string:
\REGISTRY\Machine\System\ControlSet002\Services\ati2mtag\Device0

It's necessary to use _wcsnicmp(), not wcsncmp(), in order to initialize GfxInfo correctly.　_wcsnicmp() is a case-insensitive version of wcsncmp().

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 478773 [details] [diff] [review]
case-insensitive comparison for DeviceKey of DISPLAY_DEVICE

This doesn't need superreview. It would also be good to add a comment about why a case insensitive compare needs to be used. Something like: /* some systems have a DeviceKey starting with \REGISTRY\Machine\ so we need to compare case insenstively */

Comment 10

[Tetsuro Kato (tete)]

Attachment: case-insensitive comparison for DeviceKey of DISPLAY_DEVICE v2

Added a comment why we need a case-insensitive comparison.

Comment 11

[Tetsuro Kato (tete)]

Attachment: Screenshot of Graphics info

I've confirmed the latest tinderbox build can show graphics information on my system.

Comment 12

[Scoobidiver (away)]

Push :
http://hg.mozilla.org/mozilla-central/rev/0fa5626cec95

Leave it open because there is still driver version and date issue.
For unknown Adapter RAM issue, it is bug 591787.

Comment 13

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #12)
> Push :
> http://hg.mozilla.org/mozilla-central/rev/0fa5626cec95
> 
> Leave it open because there is still driver version and date issue.

Let's open a different bug for those issues and resolve this one.

Comment 14

[Scoobidiver (away)]

For the driver version and date issue, I filed bug 600280.

Comment 15

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #14)
> For the driver version and date issue, I filed bug 600280.

Great, thanks.

Comment 16

[Barry Marshall]

Confirmed, WFM now (except the Adapter RAM) with Nightly builds.  Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100928 Firefox/4.0b7pre