595371 - Do the right thing when app tabs open/close

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Ian Gilman [:iangilman]]

Is it possible for an app tab that wasn't present at start to suddenly open? I suppose with session restore. At any rate, if it happens, GroupItems should add the tab to their app tab trays.

Likewise if an app tab closes during a session (presumably more likely), it should be removed from the app tab trays.

Comment 3

[Ian Gilman [:iangilman]]

Attachment: patch v1

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 477673 [details] [diff] [review]
patch v1

Why rename handleTabPin/handleTabUnpin? Doesn't really seem much clearer, and introduces an inconsistency with same method on TabItems.

r=me either way, but I think I'd prefer omitting the rename (unless there some reason for it that I'm missing).

Comment 5

[Ian Gilman [:iangilman]]

(In reply to comment #4)
> Why rename handleTabPin/handleTabUnpin? Doesn't really seem much clearer, and
> introduces an inconsistency with same method on TabItems.

Whereas those routines were originally just called in response to pin/unpin events, they're now also called from tab open/close events. The routines are now named after what they do, rather than who calls them.

Comment 6

[Ian Gilman [:iangilman]]

Pushed to panorama-central: 

http://hg.mozilla.org/users/ian_iangilman.com/panorama-central/rev/4b0406ab0abc

Comment 7

[Ian Gilman [:iangilman]]

Landed on mozilla-central:

http://hg.mozilla.org/mozilla-central/rev/4b0406ab0abc

Comment 8

[Tracy Walker [:tracy]]

verified in recent nightly build of minefield