595533 - Characters are sometimes ignored when typing a filter search very fast

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Sylvain Pasche]

If you open Panorama and type two or more characters very quickly, the second typed character is sometimes ignored. So if you type "abc", you may end up with a search for "ac". I'm seeing this on Windows and I couldn't reproduce in my Linux vm.

Comment 2

[Aza Raskin [:aza]]

My guess is that this is because the input box hasn't received focus yet.

Comment 3

[Aza Raskin [:aza]]

This is a data-loss issue (although not a very bad one). I'm bumping it up to beta 8 because I think it is a quick win.

Comment 4

[Ian Gilman [:iangilman]]

Assigning to Anant, assuming Sean hasn't started work on it.

Comment 5

[Raymond Lee [:raymondlee]]

This works for me on my windows 7 with latest nightly build.  Sylvain: do you still see the issue?

Comment 6

[Sylvain Pasche]

No, works for me too now (Windows 7).

Can anyone test on Linux?

Comment 7

[Sylvain Pasche]

I spoke too soon. I can still reproduce the issue on my laptop (Windows 7 too). There might be something hardware/driver related that makes it reproducible or not.

Comment 8

[Anant Narayanan [:anant]]

I am unable to reproduce the issue either on Windows 7 or Mac OS X. I tried typing as fast as I could! Likely to be a driver / hardware specific issue.

Comment 9

[Ian Gilman [:iangilman]]

Yes, it has to do with the CPU speed of your machine. Grab a crappy netbook and you should be able to repro it no problem.

Comment 10

[Sylvain Pasche]

Another way to reproduce (even if you have a fast machine) is to open a lot of tabs. With 50 open tabs I can see the issue easily.

Comment 11

[Ian Gilman [:iangilman]]

Note that the patch for bug 597399 changes from using keydown to using keypress... perhaps this will allow us to get rid of the setTimeout in ensureSearchShown, which is probably what's causing this bug.

Comment 13

[Sylvain Pasche]

Attachment: Extension that removes the setTimeout in ensureSearchShown

I can confirm that the setTimeout in ensureSearchShown is causing the issue. Do you remember why it's needed? I tried to remove it and it seems to still work fine on Windows and Linux. The attached extension patches ensureSearchShown to remove the setTimout.

Comment 14

[Kevin Hanes]

Moving over to Raymond

Comment 15

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 16

[Kevin Hanes]

Moving to b9

Comment 17

[Ian Gilman [:iangilman]]

Comment on attachment 496739 [details] [diff] [review]
v1

Raymond, the patch looks fine, but it's going to conflict with bug 610821 (specifically "Patch for tabview v1.0"); let's hold off on this until that one lands.

Comment 18

[Raymond Lee [:raymondlee]]

(In reply to comment #17)
> Comment on attachment 496739 [details] [diff] [review]
> v1
> 
> Raymond, the patch looks fine, but it's going to conflict with bug 610821
> (specifically "Patch for tabview v1.0"); let's hold off on this until that one
> lands.

It looks like the "Patch for tabview v1.0" would also fix this because it removes the setTimeout() in the  ensureSearchShown().

Comment 19

[Kevin Hanes]

bugspam (moving b9 to b10)

Comment 20

[Kevin Hanes]

bugspam (removing b9)

Comment 21

[Raymond Lee [:raymondlee]]

Bug 610821 also fixes this.

Comment 22

[Tracy Walker [:tracy]]

verified with nightly build of minefield.