595925 - Use OpenUnsharedDatabase in cookies (should fix intermittent test_cookies_read.js | command timed out: 300 seconds without output)

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[[e-mail]]

OpenDatabase shares a cache, which apparently will cause contention between the sync read and the async read/write threads.

http://mxr.mozilla.org/mozilla-central/source/netwerk/cookie/nsCookieService.cpp#735

We should also update the interface doc (http://mxr.mozilla.org/mozilla-central/source/storage/public/mozIStorageService.idl#109) to state that using an unshared connection is a good idea when cache contention is expected.

(Side note: should we be using mozIStorageConnection::connectionReady before using the database?)

Comment 1

[Shawn Wilsher :sdwilsh]

(In reply to comment #0)
> (Side note: should we be using mozIStorageConnection::connectionReady before
> using the database?)
No, the IDL appears to be wrong :(

Comment 2

[[e-mail]]

Attachment: patch

Not sure if http://mxr.mozilla.org/mozilla-central/source/storage/public/mozIStorageService.idl#73 should also be removed (or rephrased, in both cases).

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 474751 [details] [diff] [review]
patch

r+a=sdwilsh

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 474751 [details] [diff] [review]
patch

Actually, we need to get rid of exclusive locking too, which I thought we already did, but apparently did not do.  r=sdwilsh with that change.

Comment 6

[[e-mail]]

This gives us a perf improvement from 16.6ms per async operation (!) to 284us per operation. Landing this will resolve the shutdown hangs some people have been seeing. We need this so bad.

Comment 9

[[e-mail]]

We need WAL for this, or we're going to run into sync connections failing to open because of writes occurring in the background. The alternative is to add sleep() calls to the sync connection code, which is really not cool.

Comment 10

[Jim Jeffery not reading bug-mail 1/2/11]

Possible that this is causing cookie failure when restarting the browser and you find that your logged out of forums?

Comment 11

[[e-mail]]

http://hg.mozilla.org/mozilla-central/rev/c477fdd59402

Comment 12

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Could this have caused bug 605835?

Comment 14

[Chiranjit Dey]

https://www.tricksbysmt.com/