597404 - History sync: Null id for anno! (invalid uri)

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

There have been reports of history sync failing because of this exception, thrown by Utils.anno() when the URI that was passed is null. It looks like there's an edge case where places provides an invalid or null URI and we don't handle it gracefully. If anything we could do better error reporting here.

Comment 1

[Philipp von Weitershausen [:philikon]]

Firefox 4.0 beta6 user:
http://groups.google.com/group/mozilla-labs-weave/browse_thread/thread/6d58bbaf2be3bca8

Firefox 3.6.10 + Sync 1.4.4 user:
http://groups.google.com/group/mozilla-labs-weave/browse_thread/thread/cd6ffe0b5e6f20ee

Comment 2

[Philipp von Weitershausen [:philikon]]

Another case:
http://groups.google.com/group/mozilla-labs-weave/browse_thread/thread/16bf51a859777f7f

Comment 5

[[e-mail]]

Hello I join this bug. (Installed 1.5). I'd like a lot to use Sync well.  Hoping to get a good fix soon. Just as a last trial I deleted Firefox history and now sync works.

Comment 9

[[e-mail]]

i do not understand the explanation? what to do? what does this mean? please clarify what to do about fixing the problem? I unchecked history in sync and it seems to work, but that doesn't seem to be mentioned here? again what to do about fixing this? is it a bug that can be fixed ?

Comment 10

[Philipp von Weitershausen [:philikon]]

Attachment: wallpaper v1

Here's a wallpaper patch that makes the history engine handle invalid URIs in the places DB gracefully. Wallpaper because this doesn't fix the root cause, though I'm not even sure Sync could do anything about the root cause. Hopefully with the logging in place we'll be able to collect some data on these URIs.

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 482928 [details] [diff] [review]
wallpaper v1

r=me, please land on branch and trunk.

Comment 12

[Philipp von Weitershausen [:philikon]]

default: http://hg.mozilla.org/services/fx-sync/rev/34a11e14b033
1.5.x: http://hg.mozilla.org/services/fx-sync/rev/81dc17f317ad

Comment 14

[webmaster]

Hopefully this is the right place to put this:  Sync still does not work on one of my computers.

Works on P4 Win XP 32 bit. 3.6.12
Does not work on AMD 4-core Win7 64 bit.  3.6.12

Tried disconnect, connect. sync now.  Tray message says "Error While Syncing".  Does not show "Last Update:..." on mouse-over like the XP machine.

My background is in midrange database systems, so I won't be much help in debugging on my own.  But, I can usually follow instructions with only minor casualties.

Comment 15

[Eugene Kanter]

This may look like the same error. Latest sync 1.6.1

Could not create URI: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService.newURI] Stack trace: Weave_makeURI()@util.js:1000 < HistStore_update()@history.js:359 < HistStore_create()@history.js:340 < Store_applyIncoming()@stores.js:66 < anonymous()@engines.js:486 < innerBind()@util.js:1381 < anonymous()@collection.js:154 < Channel_onDataAvail()@resource.js:451

Comment 16

[Philipp von Weitershausen [:philikon]]

(In reply to comment #15)
> This may look like the same error. Latest sync 1.6.1
> 
> Could not create URI: Component returned failure code: 0x804b000a
> (NS_ERROR_MALFORMED_URI) [nsIIOService.newURI] Stack trace:
> Weave_makeURI()@util.js:1000 < HistStore_update()@history.js:359 <
> HistStore_create()@history.js:340 < Store_applyIncoming()@stores.js:66 <
> anonymous()@engines.js:486 < innerBind()@util.js:1381 <
> anonymous()@collection.js:154 < Channel_onDataAvail()@resource.js:451

This looks like a different issue, please file a new bug.

Comment 17

[[e-mail]]

Guys,

I'm having the same issue.  Firefox 3.6.13; Sync Version 1.6.2
Cannot sync History...from about:sync-log

5000 outgoing items pre-reconciliation
2011-01-28 15:11:58	Store.History        WARN	Attempted to process invalid URI, skipping
2011-01-28 15:11:58	Engine.History       DEBUG	Total (ms): sync 22432, processIncoming 21223, syncStartup 1198, findDupe 197, createRecord 4012, isEqual 4042, deleteId 18, handleDupe 60, reconcile 13152, syncCleanup 6
2011-01-28 15:11:58	Service.Main         DEBUG	history failed: NS_ERROR_XPC_JS_THREW_STRING JS Stack trace: Channel_onStopRequest([object XPCWrappedNative_NoHelper],null,2153185310)@resource.js:444 < Res__request(...)@resource.js:357 < Res_get()@resource.js:376 < SyncEngine__processIncoming()@engines.js:511 < ()@engines.js:203 < SyncEngine__sync()@engines.js:768 < wrappedSync(null)@util.js:168 < runInBatchMode([object Object],null)@:0 < batchedSync()@util.js:174 < ()@engines.js:203 < WrappedNotify()@util.js:147 < Engine_sync()@engines.js:213 < WeaveSvc__syncEngine([object Object])@service.js:1739 < ()@service.js:1625 < WrappedNotify()@util.js:147 < WrappedLock()@util.js:119 < WrappedCatch()@util.js:97 < sync()@service.js:1530 < (0)@sync.js:380
2011-01-28 15:11:58	Engine.Passwords     INFO	1 outgoing items pre-reconciliation

Comment 18

[Philipp von Weitershausen [:philikon]]

(In reply to comment #17)
> I'm having the same issue.  Firefox 3.6.13; Sync Version 1.6.2
> Cannot sync History...from about:sync-log

This is not the same issue. Please file a *new* bug and attach your whole Sync log. Thanks!