602911 - [Step 2] Cook up the Upload page

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

Current URL: https://addons.mozilla.org/en-US/developers/addon/submit (3 steps in...)
New URL: https://addons.mozilla.org/en-US/developers/addon/submit/2 (we're making unique URLs now)
Mockup: http://people.mozilla.com/~chowse/drop/amo/devtools/v2/Submit_02_Upload.png

Step 2 in this seedy tale involves uploading files.  This'll need some front end and back end work, so work together as appropriate.  Some notes while it's on my brain:

Backend:
- We've gotta accept a file and fire off a celery task that will validate it (I think all this code exists, jbalogh/dd know)

Frontend:
- We have an upload progress throbber.  Info on doing that is at https://developer.mozilla.org/En/Using_XMLHttpRequest#Monitoring_progress (and there are some examples online too). 
- "Validation in progress" has a cancel button in the mockup, but it shouldn't
- The validation throbber should be hitting /upload/:hash to figure out the status (see dependent bug)
- The mockup doesn't mention validation warnings - it's possible to have warnings, but that doesn't prevent an author from continuing
- If validation passes, the "continue" button is activated
- The mockup should include "Android" and "Maemo" platforms as well.  It will once bug 506282 is done.

CCing fligtar for copy

Comment 1

[Wil Clouser [:clouserw]]

See also: http://people.mozilla.com/~chowse/drop/amo/devtools/v3/addon_submission/02_upload.png

Comment 2

[Wil Clouser [:clouserw]]

It's like a rabbit hole!  Apparently we're boycotting spinners now in favor of bar charts.  The above mockups are still appropriate, but the parts defined in this interaction mockup overrule the equivalent parts from them: http://people.mozilla.com/~chowse/drop/amo/devtools/v3/interaction/addon_upload.png

Comment 3

[Wil Clouser [:clouserw]]

This should use the same backend code for handling uploads as bug 599042

Comment 5

[Justin Scott [:fligtar]]

intro copy:
Use the fields below to upload your add-on package and select any platform restrictions. After upload, a series of automated validation tests will be run on your file.

platform copy:
If you have additional platform-specific files to upload, you may do so at the end of this initial submission process.

Please list XPI, JAR, and XML files as .xpi, .jar, and .xml.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Also, you'll need to do a amo.LOG.CREATE_ADDON event.

Comment 7

[Potch [:potch]]

(In reply to comment #6)
> cc: [e-mail], you'll need to do a amo.LOG.CREATE_ADDON event.

Is this true? or do we need to wait until the entire upload process is complete?

Comment 8

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Hrm, yes, you are correct we do need to wait...

Comment 9

[Jeff Balogh (:jbalogh)]

This is like the new version page (bug 606280) but with a new add-on on top.  I will return it to the loving care of potch when the backend works.

Comment 10

[Jeff Balogh (:jbalogh)]

Started the backend in http://github.com/jbalogh/zamboni/commit/499d239.

Comment 11

[Jeff Balogh (:jbalogh)]

I saw that potch has most of the page markup going already, so the parts left for me are passing the platform through and setting up the submission steps.  We can work together on the platforms once he has the page going and steps are bug 610546.

Comment 12

[Potch [:potch]]

http://github.com/jbalogh/zamboni/commit/c9c4c06