570563 - Do not allow developers to specify platforms for search engines

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: disabled button

user agent:Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

steps to reproduce:
1.Go to https://preview.addons.mozilla.org/en-US/firefox/addon/129686/
2.Notice that the install button is faded-out.
3.Log in as an admin and navigate to the edit add-on page->versions and Files.Check if the developer has set the platform to anything

expected behavior:
Search engines are platform independent.So developers should not be given the option to choose platforms when they upload search engines.

actual behavior:
We allow developers to specify platforms for search engines because of which,some search engines have faded-out install buttons

Comment 1

[krupa raj[:krupa]]

Attachment: platform set

Comment 2

[Dave Garrett]

See also bug 502473 & bug 439341.

Comment 3

[Andy McKay]

After chatting to Wil, also need to:

- set the platform to all if the file is for a search engine addon

- migrate all search engine addon files with a platform other than All to be All

- do something with any conflicts (hope there aren't any)

Comment 4

[Andy McKay]

There's about 20 search engine type Addon - Version combinations with more than one file (in my data set, so likely more on production).

Comment 5

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/e06830ed8ef5836be4c2d1e44ecc0f597e1e021d

There's two management commands to run:

manage.py search_platforms --report

This will list all the addons that have a conflict, by setting the platform to All, you've now got multiple files for that version and platform. And by extension multiple install buttons. In testing there's about 20 of these and no obvious easy system to cleaning them.

This can be done at any time and run multiple times until happy with the data.

manage.py search_platforms --change

This will change any search add on platforms that aren't all to be All.