Closed Bug 604666 Opened 15 years ago Closed 15 years ago

Port bug 577213 - Set minimum required OS version for Mac builds

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

This patch/port sets a minimum version for our Mac builds on trunk. We probably won't need it when we take bug 583318 as well, but seeing as Firefox have both, then I think we should match them for now. Note that I'm not implementing bug 583318 at this stage - that can wait until each app is ready to put 64 bit builds live (I'll file patches elsewhere later).
Attached patch The fixSplinter Review
Attachment #483490 - Flags: review?(bugspam.Callek)
(In reply to comment #0) > Note that I'm not implementing bug 583318 at this stage - that can wait until > each app is ready to put 64 bit builds live (I'll file patches elsewhere > later). This is already in: http://hg.mozilla.org/comm-central/rev/cbc4d2746097
OS: Mac OS X → All
(In reply to comment #2) > (In reply to comment #0) > > Note that I'm not implementing bug 583318 at this stage - that can wait until > > each app is ready to put 64 bit builds live (I'll file patches elsewhere > > later). > > This is already in: > http://hg.mozilla.org/comm-central/rev/cbc4d2746097 Sorry, I meant bug 589391
Attachment #483490 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 483490 [details] [diff] [review] The fix Nit: Please use tabs as in the surrounding code instead of spaces.
Comment on attachment 483490 [details] [diff] [review] The fix ...actually on second thought, I want stefanh to rubber-stamp the SeaMonkey side of this. I don't forsee a problem, but as the de-facto mac owner its good to consult.
Attachment #483490 - Flags: review?(stefanh)
Comment on attachment 483490 [details] [diff] [review] The fix + <string>10.5</string> From http://developer.apple.com/library/ios/#documentation/general/Reference/InfoPlistKeyReference/Articles/LaunchServicesKeys.html: "LSMinimumSystemVersion (String - iOS, Mac OS X) indicates the minimum version of Mac OS X required for this application to run. This string must be of the form n.n.n where n is a number. The first number is the major version number of the system. The second and third numbers are minor revision numbers. For example, to support Mac OS X v10.4 and later, you would set the value of this key to "10.4.0"." It might works as it is, but to be on the safe side, you probably want "10.5.0".
Attachment #483490 - Flags: review?(stefanh) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/20144730e2b7 I forgot about spaces -> tabs, but I'll do that in the follow-up patches that we'll need for enabling 64 bit builds.
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: