605245 - Linux progress throbber should not be Ubuntu specific (ugly orange)

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Matthew Turnbull [Bluefang]]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20101018 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20101018 Firefox/4.0b8pre

The Linux throbber appears to be Ubuntu specific, as that the only Linux distro (that I know of) which uses that particular orange/brown color palette by default.

If there isn't a way to [automatically] change the throbber colors during run time, then the color scheme should cater to the default/common GNOME palettes, which are largely blue based. For example, the pinstripe throbber fit fairly well with the GNOME 2.30 Clearlooks theme.

Canonical already maintains their own Firefox package, with their own extension. If they want to change Firefox's theme to match Ubuntu's, then they should be the ones to do it; not Mozilla.

Reproducible: Always

Comment 1

[Dave Garrett]

Confirming. The blue was nice. The orange is ugly and has nothing to do with my theme at all. Either revert to the old blue or get the color via the theme colors somehow and apply a CSS filter over a neutral APNG. (which, frankly, if doable would be nice on all platforms)

Comment 2

[Dave Garrett]

(In reply to comment #0)
> Canonical already maintains their own Firefox package, with their own
> extension. If they want to change Firefox's theme to match Ubuntu's, then they
> should be the ones to do it; not Mozilla.

Ditto. Default on our end should be for GTK/GNOME which as Matthew said is better suited to be blue. Would also look better in KDE which likes blue even more.

Comment 3

[Johnathan Nightingale [:johnath]]

shorlander - would like a blocking call here, too. My thinking is "not blocking, but worth fixing if it's just a colour swap" and so I'm speculatively minusing, but if you agree that it looks blockingly bad and can easily be made to look better, renom.

Comment 4

[Aleksei Perepelkin [:chaos]]

Attachment: Working demonstration using throbber from fx 4.0b12

Added attachment with demo using simplified filter from Inkscape's predefined "Colorize" filter. May be this would help speed up fixing this bug. Also using this filter may cause more cpu usage, but I didn't notice any difference with or without using it.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8641251 [details] [diff] [review]
Patch

Please get ui-review first.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8641251 [details] [diff] [review]
Patch

Philipp, are you OK with us changing the Linux loading throbber to blue, matching what we're now shipping on Windows and OSX? Linux is currently shipping an orange loading throbber.

Comment 8

[arni2033]

Attachment: Note - NEW googlechrome-like loading icon is barely visible on Developer Themes.png

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)
> changing loading throbber to blue,
> matching what we're now shipping on Windows and OSX

FYI, NEW googlechrome-like loading icon is barely visible on Developer Themes (on Linux as well)
// I just thought that making things right from the start is better than fixing them later.

Comment 9

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Jared, do you happen to have a screen shot of that?
Generally I'm in favor of making them blue everywhere, but it creates some issues as arni2033 pointed out. It's not amazing on the default (blue) Windows XP theme as well.

Comment 10

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Stephen, do you have any thoughts on the blue-on-blue-background problem (see last two comments)?

Comment 11

[firefox]

(In reply to Dave Garrett from comment #1)
> Confirming. The blue was nice. The orange is ugly and has nothing to do with
> my theme at all. Either revert to the old blue or get the color via the
> theme colors somehow and apply a CSS filter over a neutral APNG. (which,
> frankly, if doable would be nice on all platforms)

I'd also like to see the CSS-Solution.
This would also provide a long-term solution to Bug 1177136 as well as almost any other problems that can occur with the trobber.
Also easy adjustment of throbber-colour via about:config

Comment 12

[Stephen Horlander [:shorlander]]

(In reply to Philipp Sackl [:phlsa] (Firefox UX) please use needinfo from comment #10)
> Stephen, do you have any thoughts on the blue-on-blue-background problem
> (see last two comments)?

I am fine with switching to a blue spinner everywhere. We could use a white spinner in cases where we know the background color.

Comment 13

[Stephen Horlander [:shorlander]]

(In reply to firefox from comment #11)
> (In reply to Dave Garrett from comment #1)
> > Confirming. The blue was nice. The orange is ugly and has nothing to do with
> > my theme at all. Either revert to the old blue or get the color via the
> > theme colors somehow and apply a CSS filter over a neutral APNG. (which,
> > frankly, if doable would be nice on all platforms)
> 
> I'd also like to see the CSS-Solution.
> This would also provide a long-term solution to Bug 1177136 as well as
> almost any other problems that can occur with the trobber.
> Also easy adjustment of throbber-colour via about:config

I played with using CSS animations on an SVG image: http://people.mozilla.org/~shorlander/mockups-interactive/spinner-test/spinner-01-svg.html

It works ok. Downside is that the animation makes it a little blurry.

Comment 14

[firefox]

(In reply to Stephen Horlander [:shorlander] from comment #13)
> (In reply to firefox from comment #11)
> > (In reply to Dave Garrett from comment #1)
> 
> I played with using CSS animations on an SVG image:
> http://people.mozilla.org/~shorlander/mockups-interactive/spinner-test/
> spinner-01-svg.html
> 
> It works ok. Downside is that the animation makes it a little blurry.

If someone could put that into a patch and make the color changeable via about:config (See Attachment 8642364 [details] ). That would be great

Comment 15

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Comment on attachment 8641251 [details] [diff] [review]
Patch

Via Stephens comment...

A dynamic solution would still be nice, since we are running into more and more special cases here (winxp on background tabs, but not foreground tabs; devedition on foreground tabs, but not on background tabs...)

Comment 16

[arni2033]

I'll just leave 2 words here "btw" (not going to argue but maybe you just missed the following)
Green is perfect choice for throbber because it's never used in OS UI. Now throbbers will be Less visible on standart Win7+ themes: Blue is less visible on (light)gray background than Green, that's True.

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

Philipp, sorry for the delay. Which screenshot would you like to see regarding comment #9? Note that there is a screenshot attached to comment #8.

Comment 18

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #17)
> Philipp, sorry for the delay. Which screenshot would you like to see
> regarding comment #9? Note that there is a screenshot attached to comment #8.

I was looking for a screen shot of the blue spinner on Linux, but it's actually not that hard to imagine, so nevermind :)


(In reply to Stephen Horlander [:shorlander] from comment #13)
> I played with using CSS animations on an SVG image:
> http://people.mozilla.org/~shorlander/mockups-interactive/spinner-test/
> spinner-01-svg.html
> 
> It works ok. Downside is that the animation makes it a little blurry.

Would it be possible to use that and thereby use a blue spinner everywhere except for
- DevEdition selected tab
- Windows XP background tabs with Luna Blue or Classic themes
- Windows Classic theme in general

White would probably work fine in those cases.