606990 - Remove CAIRO_HAS_DDRAW_SURFACE/CAIRO_DDRAW_USE_GL dead code

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Bug 600714 will make it dead.

Comment 1

[Emmanuel Gil Peyrot]

Attachment: Patch

Vlad, could you review widget and gfx changes?

Comment 2

[Emmanuel Gil Peyrot]

Comment on attachment 490395 [details] [diff] [review]
Patch

Bobby, could you review libpr0n changes?

Comment 3

[Emmanuel Gil Peyrot]

RENDER_IMAGE_DDRAW16 is set (in gfxWindowsPlatform.cpp) but never used now, with this patch.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 490395 [details] [diff] [review]
Patch

(In reply to comment #2)
> Comment on attachment 490395 [details] [diff] [review]
> Patch
> 
> Bobby, could you review libpr0n changes?

Not right now, but joe can!

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 490395 [details] [diff] [review]
Patch

Looks good to me; the ddraw surface has some useful shader code for when we want to do compositing using GL, but we'll have it in hg.

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 490395 [details] [diff] [review]
Patch

Approval request: this is removing a lot of dead code. This should not be risky but, in another hand, removing dead code could also wait for branching...

Comment 7

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/7f5cd850578e

We are looking forward for other contributions Emmanuel :)

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Yeah! Thanks Emmanuel

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> RENDER_IMAGE_DDRAW16 is set (in gfxWindowsPlatform.cpp) but never used now,
> with this patch.

Bug 600714 comment 0:
{
we don't care about Wince anymore
}

http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxWindowsPlatform.cpp#238
{
242 /* Pick the default render mode differently between
243  * desktop, Windows Mobile, and Windows CE.
244  */
245 #if defined(WINCE_WINDOWS_MOBILE)
246     mRenderMode = RENDER_IMAGE_DDRAW16;
247 #elif defined(WINCE)
248     mRenderMode = RENDER_DDRAW_GL;
249 #else
250     mRenderMode = RENDER_GDI;
251 #endif
}

***

Indeed, it looks like a few more occurrences could be remove, see
http://mxr.mozilla.org/mozilla-central/search?string=DDRAW&case=1
"Found 14 matching lines in 6 files"

Could that be done here too? Or file another follow-up bug? Thanks.

Comment 10

[Matheus Kerschbaum]

(In reply to comment #9)
> Bug 600714 comment 0:
> {
> we don't care about Wince anymore
> }

Filed bug 614720.

> Indeed, it looks like a few more occurrences could be remove, see
> http://mxr.mozilla.org/mozilla-central/search?string=DDRAW&case=1
> "Found 14 matching lines in 6 files"
> 
> Could that be done here too? Or file another follow-up bug? Thanks.

Filed bug 614721.