Closed Bug 606990 Opened 9 years ago Closed 9 years ago

Remove CAIRO_HAS_DDRAW_SURFACE/CAIRO_DDRAW_USE_GL dead code

Categories

(Core :: Graphics, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: Gavin, Assigned: bugs)

References

Details

(Whiteboard: [good first bug][ptf])

Attachments

(1 file)

Bug 600714 will make it dead.
Depends on: 600714
Severity: normal → trivial
Flags: in-testsuite-
Whiteboard: [good first bug]
Version: unspecified → Trunk
Attached patch PatchSplinter Review
Vlad, could you review widget and gfx changes?
Attachment #490395 - Flags: review?(vladimir)
Comment on attachment 490395 [details] [diff] [review]
Patch

Bobby, could you review libpr0n changes?
Attachment #490395 - Flags: review?(bobbyholley+bmo)
Assignee: nobody → bugs
Whiteboard: [good first bug] → [good first bug][ptf]
Status: NEW → ASSIGNED
RENDER_IMAGE_DDRAW16 is set (in gfxWindowsPlatform.cpp) but never used now, with this patch.
Comment on attachment 490395 [details] [diff] [review]
Patch

(In reply to comment #2)
> Comment on attachment 490395 [details] [diff] [review]
> Patch
> 
> Bobby, could you review libpr0n changes?

Not right now, but joe can!
Attachment #490395 - Flags: review?(bobbyholley+bmo) → review?(joe)
Comment on attachment 490395 [details] [diff] [review]
Patch

Looks good to me; the ddraw surface has some useful shader code for when we want to do compositing using GL, but we'll have it in hg.
Attachment #490395 - Flags: review?(vladimir) → review+
Attachment #490395 - Flags: review?(joe) → review+
Comment on attachment 490395 [details] [diff] [review]
Patch

Approval request: this is removing a lot of dead code. This should not be risky but, in another hand, removing dead code could also wait for branching...
Attachment #490395 - Flags: approval2.0?
Attachment #490395 - Flags: approval2.0? → approval2.0+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/7f5cd850578e

We are looking forward for other contributions Emmanuel :)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
(In reply to comment #3)
> RENDER_IMAGE_DDRAW16 is set (in gfxWindowsPlatform.cpp) but never used now,
> with this patch.

Bug 600714 comment 0:
{
we don't care about Wince anymore
}

http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxWindowsPlatform.cpp#238
{
242 /* Pick the default render mode differently between
243  * desktop, Windows Mobile, and Windows CE.
244  */
245 #if defined(WINCE_WINDOWS_MOBILE)
246     mRenderMode = RENDER_IMAGE_DDRAW16;
247 #elif defined(WINCE)
248     mRenderMode = RENDER_DDRAW_GL;
249 #else
250     mRenderMode = RENDER_GDI;
251 #endif
}

***

Indeed, it looks like a few more occurrences could be remove, see
http://mxr.mozilla.org/mozilla-central/search?string=DDRAW&case=1
"Found 14 matching lines in 6 files"

Could that be done here too? Or file another follow-up bug? Thanks.
(In reply to comment #9)
> Bug 600714 comment 0:
> {
> we don't care about Wince anymore
> }

Filed bug 614720.

> Indeed, it looks like a few more occurrences could be remove, see
> http://mxr.mozilla.org/mozilla-central/search?string=DDRAW&case=1
> "Found 14 matching lines in 6 files"
> 
> Could that be done here too? Or file another follow-up bug? Thanks.

Filed bug 614721.
You need to log in before you can comment on or make changes to this bug.