RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: jmaher, Assigned: armenzg)

Tracking

other
x86
Linux
Dependency tree / graph
Bug Flags:
needs-treeclosure +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [talos][buildduty])

(Reporter)

Description

8 years ago
we have landed some patches to clean up talos a bit more and during the next talos downtime we need to update talos.zip.

You can get talos.zip from:
http://people.mozilla.org/~jmaher/talos.zip

The two bugs which were fixed depend on this bug.
I am going to assume this requires a treeclosure.  This is going to happen next week at the earliest.
Flags: needs-treeclosure?
(Reporter)

Comment 2

8 years ago
yeah, a tree closure is usually needed for talos updates.  Next week works fine.
(Reporter)

Updated

8 years ago
Blocks: 608569
Priority: -- → P3
Whiteboard: [talos][buildduty]
Which zip shall I land?
This:
http://people.mozilla.org/~anodelman/taloszips/5c7b44ac3599/talos.zip
or this:
http://people.mozilla.org/~jmaher/talos.zip

I would deploy it tomorrow morning on a tree-closure only if I get this answered on time.
Flags: needs-treeclosure? → needs-treeclosure+
(Reporter)

Comment 4

8 years ago
I would suspect the anodelman one since it probably includes my changes as well.  I will let Alice comment on what her zip contains...regardless we can easily create a .zip file that has all pending talos changes.

This wouldn't be a problem if a talos update include a fresh pull from hg to create the .zip.  That might be something to consider doing in the future.
5c7b44ac3599 is the most current pull and should be used.
Duplicate of this bug: 610841
Summary: update talos.zip from hg repository during the next talos downtime → update talos.zip from http://people.mozilla.org/~anodelman/taloszips/5c7b44ac3599/talos.zip
Blocks: 567401
Deployed:
ae90ded66004d69ba2d27b16dcf9adf5  /home/armenzg/talos.beforeBug610841.zip
bd57382b2f9e260529ac84f47d26d819  /home/armenzg/talos.zip

 5973983 Nov 12 06:33 /home/armenzg/talos.beforeBug610841.zip
16126922 Nov  9 16:23 /home/armenzg/talos.zip

Is it known the increased size?
(Reporter)

Comment 9

8 years ago
hmm, the talos.zip on my share is 5972769 in size, I wonder if the .zip file alice has has a tp4.zip or some additional .zip file included in it.  I looked at the patches that have landed and I don't see any new files, just small tweaks to the same files.
Triggered a new set of talos jobs for mozilla-central/f7e0aeb5462b just for reference.
(Reporter)

Comment 11

8 years ago
appears to be .hg files:

joel@joel-laptop:~$ diff -r joel alice
Only in alice/talos: .hg
Only in alice/talos: .hgtags
diff -r joel/talos/run_tests.py alice/talos/run_tests.py
241d240
<         vals = [[x, 'NULL'] for x in cd[count_type]]
243c242,245
<         utils.stamped_msg("Generating results file: " + counterName, "Started")
---
>         if cd[count_type] == []: #failed to collect any data for this counter
>           utils.stamped_msg("No results collected for: " + counterName, "Error")
>           continue
>         vals = [[x, 'NULL'] for x in cd[count_type]]
diff -r joel/talos/sample.config alice/talos/sample.config
35a36
>   browser.bookmarks.max_backups : 0 
Binary files joel/talos.zip and alice/talos.zip differ
joel@joel-laptop:~$
joel and I agreed that the bundle might be bigger but it has no effect on talos.
I added notes on https://wiki.mozilla.org/Auto-tools/staging#Talos_Changes
to help us avoid this problem again.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Assignee: nobody → armenzg
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.