608762 - Editor pages use broken InstallTrigger.install call to install add-ons

Status: RESOLVED DUPLICATE of bug 647309

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Dave Townsend [:mossop]]

Clicking the ALL link on the editor tools for an add-on attempts to run the following:

InstallTrigger.install('https://addons.mozilla.org/en-US/firefox/downloads/file/102295/outwit_pack-1.0.0.1-fx.xpi', 'OutWit Hub 1.0.0.1', '', 'sha256:c750017b572ebc6417324196f216a13216e5f65de6abd8b1a5a1ce07618ccfdc');

This is broken. You actually want:

InstallTrigger.install({
  'OutWit Hub 1.0.0.1': {
    URL: 'https://addons.mozilla.org/en-US/firefox/downloads/file/102295/outwit_pack-1.0.0.1-fx.xpi'
    Hash: 'sha256:c750017b572ebc6417324196f216a13216e5f65de6abd8b1a5a1ce07618ccfdc'
  }
});

On Firefox 3.6 we're falling back to using the href of the link so installation succeeds though it uses no hash for verification. On 4.0 we have a bug where the InstallTrigger implementation is attempting to do some very strange things breaking installation from here right now (bug 608680).

Comment 1

[Wil Clouser [:clouserw]]

Your changes are backwards compatible with current browsers, right?

Comment 2

[Dave Townsend [:mossop]]

The InstallTrigger.install call you have on the site at the moment doesn't work in any browsers anywhere ever. The version I have suggested as a replacement should work in all Firefoxes ever made. So I guess yes.

Comment 3

[Wil Clouser [:clouserw]]

perfect! :)

Comment 4

[Wil Clouser [:clouserw]]

forward duping because that one is already assigned