Open
Bug 610509
Opened 14 years ago
Updated 3 years ago
Make fullscreen mode really fullscreen
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
ASSIGNED
People
(Reporter: mnyromyr, Assigned: mnyromyr)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
Attachments
(1 file)
21.17 KB,
patch
|
Details | Diff | Splinter Review |
Bug 606297 will enable full screen mode on Mac as such, but minimal urlbar etc. are still visible. Those need to hide as well (and return eg. when hitting the top screen edge with the mouse).
Assignee | ||
Comment 1•13 years ago
|
||
Not only a Mac problem.
OS: Mac OS X → All
Hardware: x86_64 → All
Summary: Make Mac full screen mode really full screen → Make fullscreen mode really fullscreen
Assignee | ||
Comment 2•13 years ago
|
||
This patch mainly replaces our code in fullscreen.js by the corresponding code from FF's browser.js, with/plus changes to suit the suite. That means: - on F11/Cmd-Shift-F only the special fullscreen urlbar remains, vanishing slowly into the upper screen frame - on Accel-L or moving the mouse against the top screen frame, it'll appear again Note that it won't autohide if the current tab is empty (on purpose, I suppose).
Assignee: nobody → mnyromyr
Attachment #565724 -
Flags: superreview?(neil)
Attachment #565724 -
Flags: review?(stefanh)
Attachment #565724 -
Flags: feedback?(philip.chee)
Comment 3•13 years ago
|
||
I noticed at least one non-Mac bug, which is that the menubar doesn't work.
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #3) > I noticed at least one non-Mac bug, which is that the menubar doesn't work. Can you elaborate, please? Everything I tested did work (of course ^_^).
Comment 5•13 years ago
|
||
On mac, if I have a few tabs opened and hit fullscreen mode, I don't see the tab bar. I just see the url bar and the nav-bar buttons.
Comment 6•13 years ago
|
||
Comment on attachment 565724 [details] [diff] [review] port Firefox fullscreen code, v1 + // In tabs-on-top mode, move window controls to the tab bar, + // and in tabs-on-bottom mode, move them back to the navigation toolbar. + // When there is a chance the tab bar may be collapsed, put window + // controls on nav bar. + var fullscreenflex = document.getElementById("fullscreenflex"); + var fullscreenctls = document.getElementById("window-controls"); + var navbar = document.getElementById("nav-bar"); + var ctlsOnTabbar = window.toolbar.visible && navbar.collapsed; + if (fullscreenctls.parentNode == navbar && ctlsOnTabbar) { + document.getElementById("TabsToolbar").appendChild(fullscreenctls); + // we don't need this space in tabs-on-top mode, so prevent it from + // being shown + fullscreenflex.removeAttribute("fullscreencontrol"); + } + else if (fullscreenctls.parentNode.id == "TabsToolbar" && !ctlsOnTabbar) { + navbar.appendChild(fullscreenctls); + fullscreenflex.setAttribute("fullscreencontrol", "true"); + } + + var controls = document.getElementsByAttribute("fullscreencontrol", "true"); + for (var i = 0; i < controls.length; ++i) + controls[i].hidden = aShow; } No tabs-on-top functionality in SM :-) +#fullscr-toggler { + height: 1px; + background: black; Nit: hex values are nicer (do we need a colour here btw?).
Comment 7•13 years ago
|
||
Another nit: Mixing let and var.
Assignee | ||
Comment 8•13 years ago
|
||
Some preliminary comments while I try fix the issues. (In reply to neil@parkwaycc.co.uk from comment #3) > I noticed at least one non-Mac bug, which is that the menubar doesn't work. JFTR: This means that if in fullscreen mode, Alt-F doesn't open/show the File menu, etc. (In reply to Stefan [:stefanh] from comment #5) > On mac, if I have a few tabs opened and hit fullscreen mode, I don't see the > tab bar. I just see the url bar and the nav-bar buttons. That's on purpose, or rather: that's a known glitch. Actually, the tabbar should scroll/hide away with the rest of the toolbars, but our tabbar isn't a toolbar yet. I'll have a look. (In reply to Stefan [:stefanh] from comment #6) > No tabs-on-top functionality in SM :-) Yet. ;-) Throwing it out now may mean to have to ponder on how to get it in again once we implement tabs-on-top. How about just commenting out? > + background: black; > > Nit: hex values are nicer Well, I disagree, but I don't care enough to argue. ;-) > (do we need a colour here btw?). Screen edges are usually black, so it won't show, I guess. Maybe transparent works as well.
Updated•13 years ago
|
Status: NEW → ASSIGNED
Updated•13 years ago
|
Blocks: full-screen-api-sm
Comment 9•13 years ago
|
||
Note bug 639705 which will add Lion-specific fullscreen support.
Assignee | ||
Updated•12 years ago
|
Attachment #565724 -
Flags: superreview?(neil)
Attachment #565724 -
Flags: review?(stefanh)
Attachment #565724 -
Flags: feedback?(philip.chee)
You need to log in
before you can comment on or make changes to this bug.
Description
•