Bug 701714 (full-screen-api-sm)

Add support for DOM full-screen

NEW
Unassigned

Status

defect
8 years ago
4 years ago

People

(Reporter: InvisibleSmiley, Unassigned)

Tracking

(Depends on 1 bug, Blocks 1 bug)

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Note that this will have l10n impact due to the domFullScreenWarning.label entity addition.
Not requesting review until bug 610509 has been finalized.

I don't know why, but unlike with FF, the "ESC" warning message doesn't appear when triggering DOM full-screen (see comment 0 for an example). Maybe a layering issue. :-/

Karsten, you may want to move some of my fixes to your patch, namely:
* renaming of function parameters (event, forceHide)
* moving of opening curly bracket to new line (toggle, cleanup) 
* removing of curly brackets for single-command if/else (aData, aShow)
Assignee: nobody → jh
Status: NEW → ASSIGNED
This is just a s/min-// update (porting bug 701618).
Attachment #573910 - Attachment is obsolete: true
Note: We should not change the omFullScreenWarning.label string (entity value) in order to ease localizers' job (i.e. they can re-use the string from FF) in case we port this to Aurora.
Do we need:
https://hg.mozilla.org/mozilla-central/rev/816d3aca13c4
From:
Bug 704011 - mozfullscreenchange event handler assumes target is an element not a document
Blocks: 199387
Comment on attachment 574288 [details] [diff] [review]
patch on top of bug 610509 patch v1a

diff --git a/suite/themes/classic/navigator/navigator.css b/suite/themes/classic/navigator/navigator.css

This file is not used on Mac, so you'll need to add stuff (from pinstripe) to suite/themes/classic/mac/navigator.css.
(In reply to Philip Chee from comment #5)
> Do we need:
> https://hg.mozilla.org/mozilla-central/rev/816d3aca13c4
> From:
> Bug 704011 - mozfullscreenchange event handler assumes target is an element
> not a document

Yes. Citing from that bug:
"Bug 703079 changed the mozfullscreenchange event target is always the owning document, rather than the element upon entering full-screen and document on exiting.

The mozfullscreenchange handler in browser.js needs to be updated to reflect that, though the existing code still works as is."

(In reply to Stefan [:stefanh] from comment #6)
> b/suite/themes/classic/navigator/navigator.css
> 
> This file is not used on Mac, so you'll need to add stuff (from pinstripe)
> to suite/themes/classic/mac/navigator.css.

So true. Thanks for keeping a sharp eye, I don't easily spot these without a way to test it.
Attachment #574288 - Attachment is obsolete: true
Nice, the pref actually works with the existing "full" screen code too.
Nothing happening anywhere (esp. on the base bug), so since in fact I'm not actively working on this, I can just as well unassign myself for the time being.
Assignee: jh → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.