Closed Bug 61437 Opened 25 years ago Closed 25 years ago

Plain text: Latin 1 accented characters are saved as draft incorrectly using CERs

Categories

(MailNews Core :: Composition, defect, P2)

Product:
MailNews Core
Component:
Composition
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.8

People

(Reporter: futzilogik, Assigned: bugzilla)

References

Details

(Keywords: intl, Whiteboard: [nsbeta1+])

Attachments

(3 files)

Proposed fix
808 bytes, patch
Details | Diff | Splinter Review
second patch, much better
1.89 KB, patch
Details | Diff | Splinter Review
Third version, include sspitzer suggestions
8.30 KB, patch
Details | Diff | Splinter Review
My character coding is set to ISO-8859-1. Now if I write a new mail and save it as a draft, the charset of this mail will always be us-ascii and it will be encoded with 7 bit. If I send the same mail (without reopening the draft) it will be send with ISO-8859-1. Steps to reproduce: 1. write a new mail with some german umlauts (ä, ü, etc.). 2. set the mail encoding to ISO-8859-1 3. save the mail as a draft 4. send the mail later Result: The charsets differ. The saved mail in folder "drafts" contains ä for ä, ü for ü (I don't know why those entities are not resolved.) The unsent message contains ä, ü, etc. Expected results: Both messages should be stored with the same charset that has been set.
QA Contact: esther → momoi
Accepting. Rich, any idea where the problem could be?
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → mozilla0.9
This seems to be according to spec we have. For Latin 1 characters in HTML mail, we send with CERs and therefore the mail will be marked as US-ASCII for the content. For plain text mail, there are no NCRs available. So the body text will be sent sent as ISO-8859-1 with the text using Quoted printable encoding. Now if we use diffent encoding for the same format mail (HTML or plain text) between sending immediately or sending later without opening the mail msg and saved mail, that would be a bug. At initial brush, we don't seem to have that problem.
BTW, is the "send unsent msg" menu working? I was not able to do this with a 12/5/2000 Win build.
Correction: > For plain text mail, there are no NCRs available. should read: For plain text mail, there are no CERs available
*** Bug 55504 has been marked as a duplicate of this bug. ***
I was able to reproduce the problem as described by the reporter when the format is plain text. This problem does not occur when the format is HTML mail or HTML mail with plain-text format option ON. The problem summary is: Plain text Latin 1 characters are saved incorrectly as NERs when Save as draft is engaged. Once this occurs the user will have to manually correct the text -- otherwise incorrect text will be sent.
Severity: normal → major
Summary: charsets of mails differ if saved as draft or sent → Plain text: charsets of mails differ if saved as draft or sent
We probably should take care of 2 issues: A. When converting from the HTML source into plain text for saving, we should turn the CERs into either 8-bit characters or QP'ed characters. B. We should honor the QP setting option in saving as draft.
Summary: Plain text: charsets of mails differ if saved as draft or sent → Plain text: Latin 1 accented characters are saved as draft incorrectly using CERs
adding intl keyword
Keywords: intl
*** Bug 61213 has been marked as a duplicate of this bug. ***
*** Bug 60963 has been marked as a duplicate of this bug. ***
changing milestone to unknown. It will get changed back when we figure out what milestone to put this bug in.
Target Milestone: mozilla0.9 → ---
This makes SaveAsDraft unusable for German. mozilla0.9 nomination.
Keywords: mozilla0.9
Keywords: nsbeta1
marking nsbeta1+ and moving to mozilla0.8
Priority: P3 → P2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.8
*** Bug 64229 has been marked as a duplicate of this bug. ***
*** Bug 64444 has been marked as a duplicate of this bug. ***
QA contact to marina.
QA Contact: momoi → marina
*** Bug 65482 has been marked as a duplicate of this bug. ***
JF, you mentioned that you thought this one worked already. Can you comment on that?
Basically it's working for me: What's append is that your are composing a mesage using an html editor without using any html formatting. When you save the message as draft, we save the message as HTML using CERs encoding which is totally normal. But when you send the message, as this one doesn't contains any HTML formatting, it is sent as plain text and therefore it use the specified char set encoding. FYI, 4.x does exactelly the same.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
When editing message using plain text editor in NC 4.7 it saves messages normally.
as does 6.x
I can reproduce the bug with the following steps: 1. New Mail in plaintext composer 2. Type umlauts (äß) 3. Save as draft, close composer 4. Open Draft Actual result: äß Expected result: äß REOPEN.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
4.x works fine, at least the plaintext composer.
in 4.72 i have my plain text message saved to Draft in ISO-8859 and everything looks correct but in Nscp6 it is saved as us-ascii and the display is wrong
Ok, I'll look at the plain text issue
Status: REOPENED → ASSIGNED
Attached patch Proposed fix — — Splinter Review
I found the problem...
Whiteboard: [nsbeta1+] → [nsbeta1+] Fix in hand
oops, my first fix re-expose bug 41506, which is also related to bug 23904. I'll post a new one soon...
Whiteboard: [nsbeta1+] Fix in hand → [nsbeta1+]
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Fixed and checked in.
tested with 2001-01-23 Mrrunk build on Windows and Xianglan looked at Linux build, this is fixed
verifying, Latin-1 chars are saved correctly in Drafts now
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: