Visually identify status bar add-on items in the add-on bar while customizing

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Theme
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Boriss, Assigned: dao)

Tracking

Trunk
Firefox 10
Points:
---

Firefox Tracking Flags

(blocking2.0 -)

Details

(Whiteboard: [addon bar])

Attachments

(4 attachments)

(Reporter)

Description

7 years ago
Currently, there is no way to identify the "old style" status bar add-on icons as individual items in the add-on bar.  To distinguish these is important, because old icons cannot be interacted with identically to new icons (e.g., they can't be individually moved).

A different visual style is needed to show the difference between old and new icons.

Note: bug 599229 would make the old icons into a customizable icon that users can move and remove a single object
(Reporter)

Comment 1

7 years ago
Created attachment 494618 [details]
Mockup: Proposed grouping of old add-on icons in OSX and on Aero Glass
(Reporter)

Comment 2

7 years ago
Created attachment 494620 [details]
Mockup: Alternative designs for groupings, not chosen because of complexy and/or requirement for two visual levels of icons
(Assignee)

Comment 3

7 years ago
Shouldn't we just hide or dim them while customizing?
I agree that, if the visual style is changed, it should only be done when customizing the toolbar.

Also, this should not be enforcing some arbitrary fixed position, as that would make the add-on bar even less of a customizable toolbar than it already is.
Boriss, your thoughts on comment #3 and #4?

(In reply to comment #4)
> Also, this should not be enforcing some arbitrary fixed position, as that would
> make the add-on bar even less of a customizable toolbar than it already is.

I don't understand this comment. What's not customizable about the add-on bar? Can you file a bug with the problems your encountering, and cc me?

The statusbar shim isn't customizable *only* because doing so can break the add-ons that are still in it, that haven't upgraded to the add-on bar. The whole point of the shim is to not break those add-ons.

We need to visually indicate that those are different, are a block of un-customizability. If that block was amidst the customizable items, I think it'd cause more confusion than having the block locked in position at either end.
Hardware: x86 → All
Whiteboard: [addon bar] → [addon bar][needs feedback boriss]
(In reply to comment #5)
> The statusbar shim isn't customizable *only* because doing so can break the
> add-ons that are still in it, that haven't upgraded to the add-on bar. The
> whole point of the shim is to not break those add-ons.

Can the old-style icons be moved as a block? E.g. can you move the "shim" as a unit?
No, it can't be moved. See Bug 607048. But it can be 'moved' by moving other items around it. So at the very least users have a choice on where they want it placed.

So, the status-bar element gets in the way, and the align="right" it an annoyance and makes the toolbar behave differently than all the other toolbar. Anchoring the status-bar element in the middle of the toolbar would be just another thing in the way.

If the status-bar is going to be anchored somewhere, then it should be on the [traditional] far right. That way it's not in the way of the rest of the toolbar. This is something that I played around with in Bug 599225.
Blocks: 616625
(In reply to comment #7)
> So, the status-bar element gets in the way, and the align="right" it an
> annoyance and makes the toolbar behave differently than all the other toolbar.
> Anchoring the status-bar element in the middle of the toolbar would be just
> another thing in the way.

It should behave like a normal toolbar, so I filed bug 616625 for this part.
align="right" is going away in bug 616014.
Whiteboard: [addon bar][needs feedback boriss] → [addon bar][needs feedback boriss][target-betaN]
Curious and annoying, but not of blocker stock. blocking-.
blocking2.0: betaN+ → -
(Reporter)

Updated

7 years ago
Target Milestone: --- → Future
Assignee: dietrich → nobody
Summary: Group old status bar add-on icons in the new add-on bar → visually identify old status bar add-on icons in the new add-on bar

Comment 11

6 years ago
This will go away when bug 598929 is fixed.
(Assignee)

Comment 12

6 years ago
Created attachment 568932 [details] [diff] [review]
patch
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #568932 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #568932 - Flags: review? → review?(shorlander)
Comment on attachment 568932 [details] [diff] [review]
patch

Review of attachment 568932 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!
Attachment #568932 - Flags: review?(shorlander) → review+
Created attachment 572027 [details]
Screenshot

Screenshot for reference.
(Assignee)

Comment 15

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/d2e5100a53b3
Keywords: uiwanted
Summary: visually identify old status bar add-on icons in the new add-on bar → Visually identify status bar add-on items in the add-on bar while customizing
Whiteboard: [addon bar][needs feedback boriss][target-betaN] → [addon bar]
Target Milestone: Future → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/d2e5100a53b3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.