619664 - Some b8 build1 localized builds use strings from wrong languages.

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Tim Babych]

Addons page is translated into language unknown to me in Ukrainian(uk) build,
in Russian(ru) build half of the main menu is translated into wrong language.

Comment 1

[Tim Babych]

Attachment: Broken addons pane in uk build

Comment 2

[Tim Babych]

Attachment: broken main menu and addons pane in ru build

Comment 3

[Axel Hecht [:Pike]]

I'm seeing another difference between the commands the release factory does and what our nightlies do, I think:

The removal of browser/locales/merged is missing.

Ben, can you confirm?

Impact if it's that: We need to respin all locales on all platforms again. Drats.

As a remedy, I propose to rm -rf browser/locales/merged every time before running compare-locales, that is, within the loop.

Comment 4

[Rail Aliiev [:rail]]

Attachment: Remove merge directory

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 498115 [details] [diff] [review]
Remove merge directory

Why ignore_errors=True? We should certainly ignore "directory doesn't exist" errors, but I don't think we should ignore any other type -- doing a repack with remnants could lead to even more subtle errors. I don't see how to distinguish easily with rmtree so probably best to guard it behind if path.exists(mergeDir)

Comment 6

[Axel Hecht [:Pike]]

FYI, I filed bug 619690 to add an option to prune the relevant parts of the mergedir itself, but that won't happen in time for this.

Comment 7

[Rail Aliiev [:rail]]

Attachment: Remove merge directory

(In reply to comment #5)
> Why ignore_errors=True? We should certainly ignore "directory doesn't exist"
> errors, but I don't think we should ignore any other type -- doing a repack
> with remnants could lead to even more subtle errors. I don't see how to
> distinguish easily with rmtree so probably best to guard it behind if
> path.exists(mergeDir)

It was a shortcut for removing the directory and ignore first run errors (directory doesn't exist). Being a little bit paranoid here wouldn't hurt us, you are right.

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 498124 [details] [diff] [review]
Remove merge directory

http://hg.mozilla.org/build/tools/rev/169e167b1166

Comment 9

[Rail Aliiev [:rail]]

I've just checked both Russian and Ukrainian repacks. UI looks fine to me.

Tim, thanks a lot for the report!

Comment 10

[Raul Nicolae Malea]

In Romanian build 1 this problem is not resolved.

Comment 11

[Rail Aliiev [:rail]]

@Raul, could you post steps to reproduce and a screenshot?

Comment 12

[Raul Nicolae Malea]

@Rail, sorry for my mistake. I working with old build 1. A minutes ago I downloaded lastest version of build 1 beta 8 romanian language. Addons and menu page is in romanian now. Bug is resolved. Good job!

[App]
Vendor=Mozilla
Name=Firefox
Version=4.0b8
BuildID=20101214170338
SourceRepository=http://hg.mozilla.org/mozilla-central
SourceStamp=d78f9cb65e91
ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}

[Gecko]
MinVersion=2.0b8
MaxVersion=2.0b8

[XRE]
EnableProfileMigrator=1
EnableExtensionManager=1

[Crash Reporter]
Enabled=1
ServerURL=https://crash-reports.mozilla.com/submit?id=ec8030f7-c20a-464f-9b0e-13a3a9e97384&version=4.0b8&buildid=20101214170338

Comment 13

[Rail Aliiev [:rail]]

@Raul, thanks a lot for the verification!