621933 - Non-ASCII search text (e.g. Japanese) in quick filter textbox is converted/garbled to ASCII after restarting TB (use UTF-8 for session.json)

Status: RESOLVED DUPLICATE of bug 810172

(Thunderbird :: Search, defect)

Description

[Caupand]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13 ( .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7

I enter Japanese into a quick filter field.it correctly behaves.but after I reboot the thunderbird text strings are different from before.

Reproducible: Always

Steps to Reproduce:
1.Enter Japanese into a quick filter field.
2.Reboot Thunderbird
Actual Results:  
Garbled text strings

Expected Results:  
Non-garbled text strings

Comment 1

[Takeshi Kurosawa :takenspc]

Attachment: Use utf-8 for session.json

Confirmed.

The quick filter uses ASCII to read/write session.json.
We should make it use UTF-8.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Thank you very much for the patch!  This looks like exactly what we want to do.

I think it should be feasible to add a unit-test to make sure that we are properly persisting the quick filter text field in an end-to-end fashion.  This would want to happen as part of our mozmill tests.

General info on mozmill testing:
https://developer.mozilla.org/en/Thunderbird/Thunderbird_MozMill_Testing

The mozmill test it would make sense to add this test to:
http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/session-store/test-session-store.js

Helper logic for setting and checking the quick filter bar text field (see "set_filter_text" and "assert_filter_text"):
http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/shared-modules/test-quick-filter-bar-helper.js

The helper logic would want to be installed like used in:
http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/quick-filter-bar/test-filter-logic.js
specifically, lines 46 (adding an entry to MODULE_REQUIRES) and lines 54-55 (getting the module and installing its contents into the namespace).

If you need help in working with mozmill tests, please let me know.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 500745 [details] [diff] [review]
Use utf-8 for session.json

Changing review request into a feedback request; tests are required for review.

Comment 6

[Thomas D. (:thomas8)]

This must be quite annoying for users of non-ASCII languages with "sticky" enabled on Quick filter (even though it happens only once per session); for those from Europe or US, imagine your searchwords being converted to Japanese at every start of TB...

Has a patch which was probably correct at the time per :asuth's comment 2.
Was then deserted bc :asuth requested tests and assignee never replied. What a pity.

Can anyone
- check if patch still applies
- unbitrot patch if not
- provide unit tests for this bug, as outlined in comment 2?

Comment 7

[Thomas D. (:thomas8)]

(In reply to Thomas D. from comment #6)
> This must be quite annoying for users of non-ASCII languages with "sticky"
> enabled on Quick filter (even though it happens only once per session);

Oh, even without "sticky", we store the quickfilter text for the next session, so it will affect even more users.