Closed Bug 629057 Opened 13 years ago Closed 13 years ago

fix unaligned accesses in qcms on sparc64

Categories

(Core :: Graphics: Color Management, defect)

1.9.2 Branch
Sun
OpenBSD
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- .23-fixed
status1.9.1 --- .20-fixed

People

(Reporter: gaston, Assigned: gaston)

References

()

Details

(Keywords: verified1.9.2)

Attachments

(2 files)

User-Agent:       Midori/0.2 (X11; OpenBSD; U; fr-fr) WebKit/531.2+
Build Identifier: 

Followup to https://bugzilla.mozilla.org/show_bug.cgi?id=504766 (and its duplicates), this bug is still present in branches 1.9.1 and 1.9.2. Browsing a particular page on OpenBSD/sparc64 using ffx 3.6.13 crashes the browser.

Cherrypicking http://hg.mozilla.org/mozilla-central/rev/e8207773d54d fixes the issue.

Reproducible: Always
Hardware: Other → Sun
Version: unspecified → 1.9.2 Branch
Crash has been confirmed on http://www.heise.de/netze/ with ffx 3.5.16.
Attachment #521016 - Flags: review?(joe) → review?(jmuizelaar)
Attachment #521017 - Flags: review?(joe) → review?(jmuizelaar)
Attachment #521016 - Flags: review?(jmuizelaar) → review+
Attachment #521017 - Flags: review?(jmuizelaar) → review+
You should request approval
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #521017 - Flags: approval1.9.2.17?
Attachment #521016 - Flags: approval1.9.1.19?
Comment on attachment 521016 [details] [diff] [review]
Fix unaligned access for 1.9.1

1.9.1.19 is code-frozen
Attachment #521016 - Flags: approval1.9.1.19? → approval1.9.1.20?
Attachment #521017 - Flags: approval1.9.2.17? → approval1.9.2.18?
Comment on attachment 521016 [details] [diff] [review]
Fix unaligned access for 1.9.1

Approved for 1.9.1.20, a=dveditz for release-drivers
Attachment #521016 - Flags: approval1.9.1.20? → approval1.9.1.20+
Comment on attachment 521017 [details] [diff] [review]
Fix unaligned access for 1.9.2

Approved for 1.9.2.18, a=dveditz for release-drivers
Attachment #521017 - Flags: approval1.9.2.18? → approval1.9.2.18+
Whiteboard: [needs landing]?
Assignee: nobody → landry
Comment on attachment 521017 [details] [diff] [review]
Fix unaligned access for 1.9.2

Didn't make 3.6.18
Attachment #521017 - Flags: approval1.9.2.18+ → approval1.9.2.18-
And what's needed to get that commited ? approval-xxx is not enough now ?
Keywords: checkin-needed
> And what's needed to get that commited ?

Someone to do the actual push...  So either poking someone directly or adding checkin-needed.

dveditz, does this need to be reapproved for 3.6.19, or can I just push it?
Comment on attachment 521017 [details] [diff] [review]
Fix unaligned access for 1.9.2

Approved for 1.9.2.19, a=dveditz
Attachment #521017 - Flags: approval1.9.2.19+
And the other thing that would help would be posting a patch that can actually be imported into hg...
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]?
JFYI (I can fix it locally on my side but I'd like you to know it ;-))

iccread.c: In function 'read_u32':
iccread.c:91: warning: implicit declaration of function 'memcpy'
iccread.c:91: warning: incompatible implicit declaration of built-in function 'memcpy'
iccread.c: In function 'read_u16':
iccread.c:103: warning: incompatible implicit declaration of built-in function 'memcpy'

This breaks the build in our buildsystem:
I: Program is using implicit definitions of special functions.
   these functions need to use their correct prototypes to allow
   the lightweight buffer overflow checking to work.
     - Implicit memory/string functions need #include <string.h>.
     - Implicit *printf functions need #include <stdio.h>.
     - Implicit *printf functions need #include <stdio.h>.
     - Implicit *read* functions need #include <unistd.h>.
     - Implicit *recv* functions need #include <sys/socket.h>.
E: MozillaThunderbird implicit-fortify-decl iccread.c:91, 103
Right.. so it lacks a #include <string.h>. I suppose a separate bug should be opened against trunk for that ?
A new bug would be great. We will fix this soon.
It's already fixed in trunk by bug 674230 (http://hg.mozilla.org/mozilla-central/rev/77305d830151)... so i suppose a new bug should be filed against 1.9.2 branch ?
Landry, can you verify that the crash is fixed in 1.9.2 and trunk on sparc64? I don't have access to such machines.
Whiteboard: [qa-examined-192]
As i said in Bug 643137, i have limited time for that in the coming days, but i'll try 3.6.20 when possible.

Oh, and noone will never know if the crash is fixed in trunk, since it is definitely broken on sparc64, and will probably stay that way.
Firefox 3.6.20 Candidate build 1 works fine on sparc64 with the patch integrated, i can browse the offending sites http://www.heise.de/netze/ and http://www.onlinemovies.top-site-list.com/ without crashes. Thanks!
Thanks. Marking as verified for 1.9.2.
Keywords: verified1.9.2
Whiteboard: [qa-examined-192]
You need to log in before you can comment on or make changes to this bug.