631362 - Deleted message doesn't move until icon of newly selected trash folder is changed to "Trash Can" icon by collapse/re-expand of account in folder pane

Status: NEW

(Thunderbird :: Account Manager, defect)

Description

[Natalia]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US) AppleWebKit/534.10 (KHTML, like Gecko) Chrome/8.0.552.237 Safari/534.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; ru; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7

If in Account Server Settings change the folder "when I delete a message" for the second time, deleted message will not move to that folder (Yahoo account).

Reproducible: Sometimes

Steps to Reproduce:
1. Create a new folder as subfolder of mail account and name it "Test".
2. In Account settings -> server settings ->"When I delete a message" choose "Move it to this folder" and select the folder "Test".
3. Delete a message.
4. Turn to the "Test" folder.
Actual Results:  
The "Test" folder is empty.

Expected Results:  
The "Test" folder should contain deleted message.

I've tried these STR with Yahoo account and deleted message had not been saved in any folder, with Gmail account deleted message saved in Gmail/Trash.
If we set the folder in account server setting for the first time, everything works fine. But when we change the folder to the another one this bug happens.

Comment 1

[WADA:World Anti-bad-Duping Agency]

With Tb 3.1.7 on Win, with "All Folders" view of folder pane.

(a) Yahoo! Imap.
    "When I delete a message", choose "Move it to this folder",
    and select the folder "Test".
    => Icon of Trash(previously set as trash) is changed.
    Icon of Test is still icon for normal folder.
    Collaps and re-expand account.
    => Icon of Test is changed to icon for trash folder.
    Delete a mail => mail is moved to Test folder as designed, as expected.
=> WORKSFORME

(b) Gmail IMAP.
    [Gmail]/Trash is used as trash folder, regardless of folder selection
    at "Move it to tis folder".
    It's can be called "current resriction", but it's current implementation.
    Read and unerstand bugs listed in dependency for meta bug 402793, please.

POP3 of Yahoo! instead of IMAP? (local mail folder instead of IMAP folder)
With which folder pane view? "All Folders"? Or "Cnsolidated Folders"? Other?
If Yahoo! IMAP, was Trash(previous trash folder) opened before change to Test? 
Does problem on Yahoo account consistently occur even after restart of Tb?

Comment 2

[Natalia]

(In reply to comment #1)
 
> POP3 of Yahoo! instead of IMAP? (local mail folder instead of IMAP folder)
IMAP of Yahoo! is used. Creating a folder in TB=creating the folder in Yahoo. I haven't tried with POP3.

> With which folder pane view? "All Folders"? Or "Cnsolidated Folders"? Other?
I'm not sure if I understand right. Do you mean view->folders=all? If so, "All folders" are chosen.

> If Yahoo! IMAP, was Trash(previous trash folder) opened before change to Test?

Yes, it was opened previously, marked as trash folder and selected in Account Server Settings as a folder="When I delete a message". When I started TB with this settings and delete a message, everything works fine. Than I change the folder from Trash to "Test" and delete a message, the result is the "Test" folder doesn't mark as trash and the deleted message doesn't move to the "Test". The problem resolves when TB is restarted.

Comment 3

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #2)
> Yes, it was opened previously, marked as trash folder and selected in Account
> Server Settings as a folder="When I delete a message".
> When I started TB with this settings and delete a message, everything works fine.
> Then I change the folder from Trash to "Test" and delete a message, (snip)

Was icon of Trash(previous trash) changed from "trash can" to ordinal icon?
(in my test, it was changed)
Was icon of Test(new trash) changed from ordinal icon to "trash can"?
(in my test, it was not changed at this step)

> the result is the "Test" folder doesn't mark as trash
> and the deleted message doesn't move to the "Test".

Was deleted mail moved to "Trash" which was previous trash?
Or nothing was deleted and moved?

> The problem resolves when TB is restarted.

Is restart of Tb mandatory?
In my test, icon of Test wa changed from ordinal icon to "trash can" by collapse&re-expand of account who owns the Test folder, and I couldn't see problem you stated.
Can it be recovery operation of your problem?

Comment 4

[Natalia]

(In reply to comment #3)
 
> Was icon of Trash(previous trash) changed from "trash can" to ordinal icon?
> (in my test, it was changed)
Right, the prev. "Trash" folder changed to ordinal icon.

> Was icon of Test(new trash) changed from ordinal icon to "trash can"?
> (in my test, it was not changed at this step)

No, it wasn't. The icon of "Test" (new trash) remains as ordinal icon. 

> Was deleted mail moved to "Trash" which was previous trash?
> Or nothing was deleted and moved?

The deleted message doesn't move nor to the "Trash" neither to the "Test" or any of exciting folder. For instance, I delete a message from Inbox folder, it moved form the Inbox but doesn't appear in any of folders.

> Is restart of Tb mandatory?
> In my test, icon of Test wa changed from ordinal icon to "trash can" by
> collapse&re-expand of account who owns the Test folder, and I couldn't see
> problem you stated.
> Can it be recovery operation of your problem?

Collapse&re-expand of account helped in terms of folder icon, I haven't tried it earlier. But still non of the folders holds the message deleted before collapse&re-expand.

Comment 5

[WADA:World Anti-bad-Duping Agency]

I could observe phenomenon of next with your step to reproduce, with Tb 3.1.7.
(1) trash folder=Trash. delete a mail in Inbox, mail is moved to Trash
(2) Change trash=TrashXXX from Trash.
    At Server Settings, change to "Move it to this foler: TrashXXX".
    => Icon of Trash is changed from "Trash Can" to ordinal folder icon.
    => Icon of TrashXXX is not changed from ordinal folder icon to "Trash Can".
(3) Delete another mail at Inbox (call UID=XXX)
(3-1) At Inbox, uid copy XXX "trash-folder-name" is not issued,
      even though "move to trash" model is still chosen by user.
(3-2) At Inbox, uid XXX store +Flag (\Seen) is issued
(3-3) At Inbox, uid XXX store +Flag (\Seen \Deleted) is issued
=> Mail of UID=XXX is not copied to anywhere.
   i.e. Mail of UID=XXX in Inbox is lost, because "copy to trash folder" step
   is skipped or somehow fails, even though "Move to trash" model is chosen.

I'll try to get IMAP log for it.

Comment 6

[WADA:World Anti-bad-Duping Agency]

When "Empty Trash" was executed while "icon for ordinal folder" was assigned to both Trash and TrashXXX(i.e. there is no folder of "Trash Can" icon at folder pane) just after trash folder selection change, following exception was reported to Error Console by Tb 3.1.7.

> Error: An error occurred executing the cmd_emptyTrash command:
> [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
> [nsIMsgFolder.emptyTrash]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"
> location: "JS frame :: chrome://messenger/content/folderPane.js :: ftc_emptyTrash :: line 2226"  data: no]
> Source File: chrome://global/content/globalOverlay.js
Line: 100

After the exception, when account was collapsed/re-expanded, icon of previously selected trash folder was changed to "Trash Can" icon, and "Empty Trash" was executed on this "previously selected trash folder". i.e. Mismatch between current trash and "Move to this folder" selection happens, or "Move to this folder" setting(mail.server.serverN.trash_folder_name value) is ignored.
Restart of Tb looked required to resolve this mismatch.

Comment 7

[WADA:World Anti-bad-Duping Agency]

For recovery operations.
If server connection already exists(at least one folder is opened after restart of Tb), icon of newly selected trash folder is changed to "Trash Can" icon by collaps/re-expand of accout, and the newly selected trash folder is used as "trash folder" by "Delete of mail" and "Empty Trash".
If no server connection is established after restart of Tb, icon of newly selected trash folder is changed to "Trash Can" icon by open of a folder, and used as "trash folder".

External symptom of this bug;
  Newly selected trash folder at "Move it to this folder:" is not used
  as "trash folder" for "Delete of mail" and "Empty Trash",
  until icon of the "newly selected trash" is changed to "Trash Can icon"
  from "icon for ordinal folder" by collapse/re-expand of account or by first
  folder open after restart of Tb. 

Confirming.

Comment 8

[Wayne Mery (:wsmwk)]

possible dups
Bug 591722
bug 606479

Comment 9

[gene smith]

(In reply to Wayne Mery (:wsmwk) from comment #8)

possible dups
Bug 591722
bug 606479

Not sure these are really relevant. This bug (comment 0) is for imap. The 2nd bug referenced is POP. The first one doesn't mention changing the designated trash folder.

Also, I guess this bug (comment 0) is really just the fact that if you change the designated trash folder, you have to collapse/expand the folder tree or restart tb. Typical users won't know about the collapse/expand widget or why they need to use it, but it is pretty common for config changes to require a tb restart (although this seems to be frowned on with modern apps).

Maybe when config change is made something should pop up saying "A tb restart may be needed for your change to take effect" and, so "advanced" users aren't irritated, a "don't show this any more" checkbox should be included.

Comment 10

[gene smith]

I just tried this with 3 imap accounts and it worked without collapse-expand on charterr, aol (yahoo based) and gmail.

Start with Trash as trash folder (has icon)
Go to server setting and change trash destination to existing folder XXX
Come back to the normal view and folder XXX now has the icon and Trash doesn't
Delete a random messages and it goes to XXX.
Can set Trash back as trash folder in the same way and it has the icon and receives deleted messages again.

So this appears to now be INVALID but not sure why. I remember working on something like this in the past and a quick scan of the hg log brought up bug 1175446. That fix may have affected this, not sure.