63189 - Can't see/save attachments - no button!

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Brice Ruth]

When receiving mail with attachments, the preview window doesn't show an
attachment button to save off attachments.  The message list window doesn't
change the icon to indicate the message has attachments.  Opening the message in
its own window brings no relief either.  There appears to be absolutely no way
to receive attachments now.

Comment 1

[Jason Wong]

dup of 62955?

Comment 2

[Blake Ross]

*** This bug has been marked as a duplicate of 62955 ***

Comment 3

[Sebastian Späth]

indeed it is

Comment 4

[Brice Ruth]

Looking at bug 62955, I see no similarity between that bug report and this.
This isn't a dialog box that is missing buttons - I've seen that particular bug
on my system, so I know the symptoms.  This is more severe in my opinion - more
so than simply hitting enter to dismiss a pop-up dialogue.  I can't effectively
use Mail/News since I can retrieve attachments and quite frankly, Mail/News
shows no sign of recognizing that an attachment is present (see "icon in list
view doesn't change to indicate an attachment is present").

Reopening bug report in opens of (a) a better explanation of why this is a dup
or (b) a record of this particular problem.

Comment 5

[R.K.Aa.]

Reporter: Are you using "view headers - all"?
Does the attachment button return if you "view headers - normal"?
If so, this is a dup of bug 39679

Comment 6

[Bradley Hart]

I'd have to agree with Blake that this is a dupe of 62955, I recommend we wait
until that bug is fixed, and see if it fixes this problem.

Comment 7

[Brice Ruth]

Followed comments to see if button appeared after 'view headers - all' and then
'view headers - normal' ... no dice.  Recall: Mail/News gives no indication that
an attachment is present - no icon change in list view, no button in preview
pane or full message window.  Mail/News is not showing any sign of detecting
that an attachment is present with the message - none whatsoever.

Comment 8

[Bradley Hart]

I see what you are sayine. Mail does not seem to have a way too view/open an
attachment. The attachment, however, is present in the message source.

Strange, this is not that mail/news does not recognize the attachment, just that
there is no button or option to do anything with the attachment. Could this be a
UI problem...?

Regardless, I'm marking it NEW. 

Comment 9

[Bradley Hart]

Now I'm really going to mark it NEW :)

Comment 10

[Brice Ruth]

More fuel for the fire ... or food for the bug, whatever.  I recently composed
an e-mail (HTML) giving step by step instructions with a few images (JPEGs)
inserted along the way for reference.  I CC'd myself and when I opened the
message, I saw the place holder for the images, but not the images themselves
... i.e. I believe the HTML code in the message specified the size of the image,
so the mail window parsed the HTML correctly and set aside space for the image,
but didn't insert the image from the attachment.  I've verified that the images
are indeed attached properly by viewing the e-mail from a different browser.
So, not only does Mail not give buttons for attachments, but it doesn't properly
display inlined attachments in HTML messages.

Interesting ...

Comment 11

[scottputterman]

The fact that there's no attachment indication in the thread pane is a known
bug.  However, there should be an attachment button in the message pane headers.
 If you have an email that you can post publicly that exhibits this behavior,
please attach it.

reassigning to mscott.

Comment 12

[Brice Ruth]

Attachment: Sample e-mail, as requested

Comment 13

[Brice Ruth]

Here's what I did:
Created a text file (textfile.txt) and zipped it to file.zip.  In Mozilla
Mail/News, composed a new message & attached file.zip, addressed to myself
([e-mail]) and sent.
Received message, verified that I couldn't see any method to retrieve the
attachment, view all headers didn't show an attachment button, returning to
normal had no effect either.
Went to 'Save As'~'Message' and saved it as sample.mail.
I've attached sample.mail now.

Comment 14

[scottputterman]

thanks for the attachment.  62955 was marked fixed. Did this get fixed?

Comment 15

[Brice Ruth]

This bug is still present - though I can verify that the other bug is fixed
(thankfully).

Comment 16

[Scott MacGregor]

are you using view all headers mode? we didn't implement the attachment button
in view all headers mode for NS6. You only get it if you are in view normal.

go to View --> Headers and make sure it says normal.

Comment 17

[Brice Ruth]

Yep, its in normal view - I'd know if I were viewing all the headers :)

Comment 18

[Sheela Ravindran]

change qa contact -> myself
Add to cc list

Comment 19

[Sheela Ravindran]

change qa contact -> fenella

Comment 20

[Brice Ruth]

Changing affected platforms to 'All' - recently tested on Linux & Win2k as well
as MacOS.  Netscape 6 & 6.01 also show problem.  Latest Moz 0.8 shows problem as
well.

Since obviously some people are able to get attachments, it would seem that the
attachment mechanism in general isn't broken ... however, possibly certain
server configurations aren't currently compatible.

My server config is: IMAP/SSL via courier-imap & stunnel on the server side.

Comment 21

[fenella]

To Esther ..

Comment 22

[agodwin]

I'm also seeing this problem,
Mozilla 0.8 on NT4 (4.00.1381) with an Exchange mailserver (IMAP4rev1 5.5.2650.23)

Comment 23

[Fabian Guisset]

worksforme win95 mozilla0.8 and build 2001030904. I see the attachment button in
the message pane every time an attachment is sent with the message.
OS/Platform : All/All since agodwin reports the bug on NT4 also.

Comment 24

[Fabian Guisset]

forgot : severity critical and nominating for mozilla1.0 cuz this is a blocker
to mailnews for the people seeing this
Brice did you ever try with a new profile?

Comment 25

[Brice Ruth]

Fabian:
I tested w/ build 2001031309, deleted my 'Mozilla' profile directory so that it 
would be fresh - chose not to convert my Netscape 4 profile when prompted & 
created a new profile for Mozilla.  Sent myself a test message w/ attachment 
(Word doc) and saw no difference - problem is still present.

Note: this problem appears to depend heavily on the IMAP server being used - what 
IMAP server is used for your e-mail?  So far, I've experienced the problem w/ 
Courier-IMAP, someone else has noted that he sees the same behaviour w/ Exchange.

Comment 26

[Keyser Sose]

*** Bug 57844 has been marked as a duplicate of this bug. ***

Comment 27

[Keyser Sose]

*** Bug 57734 has been marked as a duplicate of this bug. ***

Comment 28

[Keyser Sose]

*** Bug 67342 has been marked as a duplicate of this bug. ***

Comment 29

[Hunter Kelly]

I have this problem with every version of mozilla I've tried,
up through 0.8.  I'm connecting to an Exchange server using IMAP.

I've also noticed that Netscape 4.76 also has this problem, 
but only occasionally, maybe on 10% of the attachments.

Comment 30

[Brice Ruth]

According to a developer I talked to in the mozilla IRC room, attachments are 
seen fine via IMAP to Netscape Mail servers (guess this isn't entirely 
surprising).  Based on the 'elusiveness' of this bug, I'm guessing that UW-IMAP 
servers don't elicit this problem either (UW-IMAP is probably the most common 
type of IMAP server in use).

My particular setup is also adds the complexity of being SSL/IMAP, but according 
to the person on IRC, their connection to the Netscape Mail server was also SSL/
IMAP - I've also tried mine w/o SSL (since I'm the server admin, that was easy 
enough to do) and I got the same behaviour.

Note: when compiling Courier-IMAP, I compile with a flag that alters its IMAP 
behaviour to allow Netscape 4.x clients to connect more successfully - apparently 
Netscape 4.x is buggy with its IMAP transport.  The README notes that this 
bugwards-compatibility mode may break clients that adhere strictly to the 
IMAP4rev1 standard - may that be the case here?  I don't really have much of an 
opportunity to recompile the system w/o the bug-compatibility mode since all mail 
clients (except for me) are accessing mail via Netscape 4.x.

Comment 31

[Brice Ruth]

Also - check out the comments for bug # 57844 - this bug was marked a dup of 
63189 and before being marked a dup, some more detailed information was provided 
(like copying a message that shows no attachment to a local folder makes the 
attachment appear).

Comment 32

[scottputterman]

marking nsbeta1+. We should investigate this since we've had multiple reports of
people not seeing attachments.

Comment 33

[Keyser Sose]

*** Bug 67345 has been marked as a duplicate of this bug. ***

Comment 34

[daltenbern]

I've discovered a bug in the imap service that causes attachment not to be
visible if you have an @ in your e-mail address.  This is due to the fact that
the NewURI routine in nsImapService is doing an nsUnescape before going to
GetPreHost and GetHost.  Because GetPreHost is looking for an @ to delineate the
userid and the hostname it is passing back only part of the userid as the userid
and then the rest as the incorrect hostname.  This causes the FindServer call
that is a few lines further on to fail which subsequently skips several things
involving the attachments.  I put in a kind of hokey fix to go to GetPreHost
before the unescape, then unescape the userid afterward and then continue.  I
now see all my imap attachments.

Comment 35

[Brice Ruth]

Excellent!!  This falls in line with the way the vpopmail is setup for virtual 
mail hosts on a qmail/courier-imap system.  The username is user@domain, so the 
IMAP user is actually something like:

user@[e-mail]

It would seem that a simple fix would be to parse the string backwards - from the 
end, the first @ encountered would delimit the host from the username, right?  I 
think this should work in all cases.

Comment 36

[Keyser Sose]

*** Bug 71777 has been marked as a duplicate of this bug. ***

Comment 37

[Fabian Guisset]

*** Bug 73751 has been marked as a duplicate of this bug. ***

Comment 38

[daltenbern]

In theory fixing this problem by scanning the url backwards sounds like a good
idea, however, without inventing new functions it won't work.  The code in
nsImapService uses a method called GetPreHost.  GetPreHost walks through the
whole url from left to right looking for special characters(/:@ and a couple of
others).  It can't be changed to go from right to left.  The only solution is
write a new function that does the scan backwards but this doesn't seem right
either.  The fix that I put in delays doing the nsUnescape until after the call
to GetPreHost.  There are some other complications due to the fact the the url
is kept in an nsXPIDLCstring in nsMailService and as far as I can tell
nsXPIDLCstrings cannot be directly passed to nsUnescape so the CString has to be
copied out to someplace else.  I copied it to an nsAutoCString.  This is the
first time I have been involved in a Mozilla bug, can somebody tell me if I
should send my fix somewhere and if so, where.

Comment 39

[[e-mail] (gone - use [e-mail] instead)]

Pretty sure Seth fixed this by checking in the little paperclip icon that
appears on a mail message.  Bug 44619

Comment 40

[Brice Ruth]

Testing on build 20010408 the problem is still present, in the same form as
previously.  Viewing the message within an IMAP folder shows no attachments,
viewing the message from a local folder shows the proper attachments.  This is
consistent with the observation that the IMAP URL is being parsed incorrectly
(since this happens with virtual mail domain servers in which the username
contains the @ symbol, e.g. [e-mail]@mailhost.domain.com).  Two plausible
fixes seem likely: rewriting the URL code to allow for this type of scheme or
reorganizing the attachment detection code to parse the URL after attachments
are determined (as discussed previously for this bug).

Comment 41

[scottputterman]

moving to mozilla0.9.1

Comment 42

[Keyser Sose]

*** Bug 77294 has been marked as a duplicate of this bug. ***

Comment 43

[Scott MacGregor]

Okay you guys have been doing some great analysis work here. Time to nip this
one in the butt and fix it.

1) I need access to a courier imap server if any of you guys have a public one I
can test against? Either that or if one of you has a debug build I can send
potential fixes to you to test. 
2) It would be really helpeful if I could see an Imap log showing us trying to
read a message with attachments. 

To do this, follow the instructions at: 
http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html#imap

Just open up your account, click on a message with an attachment. Then shut
down. Send me the log file or attach it to this bug report.

Thanks!

Comment 44

[Scott MacGregor]

Attachment: proposed fix

Comment 45

[Scott MacGregor]

Here's the fix. Thanks to Brice for helping me get an account I could test this
against. 

Comment 46

[Scott MacGregor]

Attachment: reposting patch

Comment 47

[David :Bienvenu]

sr=bienvenu

Comment 48

[Scott MacGregor]

Fix checked in. Thanks for the help everyone.

Comment 49

[esther]

Brice could you please take a build with the fix and verify you can now see 
attachments.  Thanks

Comment 50

[esther]

Hunter Kelly, could you please try a build after the fix to see if you can see 
attachments.  I tried with an Exchange server we have and did not see a problem 
before the fix so the server I'm sending to must have a different configuration 
than the one you use.  Thanks Esther

Comment 51

[Jason Baker]

As I reported in 57844, I created a test email account for you Mozilla folks to 
use... give me a shout if you need a new password or something.  Also (pardon 
the newbie question), where can I grab a Win32 build with this patch in it, as I 
don't have the build tools myself?

Comment 52

[Scott MacGregor]

some time tomorrow, go to www.mozilla.org and you can download a nightly build
from that page. I just checked it in so you want to wait for tomorrow's builds =).

Comment 53

[Scott MacGregor]

Karen, per the steps in the bug, you'll only see this problem if your user name
has an "@" sign in it. It doesn't matter what server you use. Your test01
accounts on our exchange server won't show it unless you create a new acct user
name with an '@' sign.

Comment 54

[esther]

I used the moring build on 5-7 and the test account Jason mentioned above and I 
saw the attachment button and was able to open the .jpg file.  But I couldn't 
get the context menu to display, we are having problems with attachment with 
todays builds so I will check this again after that is fixed.  We have not been 
able to create a mail account on our Exchange server with the @ sign in the 
name, so we haven't verified that server yet.  Still waiting to verify this 
completely.

Comment 55

[Karen Huang]

I already tole Esther that 
there was account on NMS 3.5 server (poisonivy.mcom.com) with @ user name.
She will verify on that account too....

Comment 56

[Karen Huang]

Oops! Typo. I mean "told"....

Comment 57

[esther]

OK, I tested this with on the test account Jason set up and an Exchange Server 
account we have here that has the @ sign in the email name.  Using 5-4 build I 
didn't see the attachment (it wasn't fixed yet).  Using the 5-7 build on win, 
mac and linux I see the attachments.  Verified