Closed Bug 631918 Opened 15 years ago Closed 15 years ago

Sync Now can briefly block the menu when not logged in

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(1 file)

Bug 597788 wrapped Service.sync() in a setTimeout call, but not the login() (which blocks, too). We shouldn't have to call it anymore, anyway. Service.sync() does it for us now.
Attached patch v1 — — Splinter Review
No need to call login(), just call sync(). Also get rid of no longer needed UI methods (the buttons were removed).
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #510136 - Flags: review?(mconnor)
Attachment #510136 - Flags: review?(mconnor)
Attachment #510136 - Flags: review+
Attachment #510136 - Flags: review+
Attachment #510136 - Flags: approval2.0?
Attachment #510136 - Flags: approval2.0? → approval2.0+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
verified with nightly minefield build of 20110218
Status: RESOLVED → VERIFIED
No longer blocks: 632433
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: