Last Comment Bug 631942 - Prevent Sync Now from blocking the menu (port bug 597788 and bug 631918)
: Prevent Sync Now from blocking the menu (port bug 597788 and bug 631918)
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Sync UI (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
Mentors:
Depends on: 597788 631918
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-06 14:36 PST by Jens Hatlak (:InvisibleSmiley)
Modified: 2011-02-21 23:43 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch [Checkin: comment 2] (949 bytes, patch)
2011-02-06 14:36 PST, Jens Hatlak (:InvisibleSmiley)
neil: review+
Details | Diff | Splinter Review

Description Jens Hatlak (:InvisibleSmiley) 2011-02-06 14:36:41 PST
Created attachment 510170 [details] [diff] [review]
patch [Checkin: comment 2]

The Tools menu is blocked when using Sync Now, for two reasons:
1. Sync login. See bug 631918.
2. Syncing. See bug 597788 (comment 3 also applies to us).
Comment 1 neil@parkwaycc.co.uk 2011-02-06 15:47:53 PST
Comment on attachment 510170 [details] [diff] [review]
patch [Checkin: comment 2]

So, the problem is that Weave.Service.sync() needs to be async... ;-)

[I noticed that Sync conflicts with Search the Web :-( ]
Comment 2 Jens Hatlak (:InvisibleSmiley) 2011-02-06 16:02:10 PST
Comment on attachment 510170 [details] [diff] [review]
patch [Checkin: comment 2]

http://hg.mozilla.org/comm-central/rev/c7d38399359a

Note You need to log in before you can comment on or make changes to this bug.