633337 - pattern viewBoxes still not treated correctly

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Robert Longson [:longsonr]]

With this http://dev.w3.org/SVG/profiles/1.1F2/test/svg/pservers-pattern-04-f.svg displays correctly.

Comment 3

[Robert Longson [:longsonr]]

Comment on attachment 511527 [details] [diff] [review]
patch

pservers-pattern-02 seems to be failing on how viewBoxes are interpreted too so I'll see if I can fix that too.

Comment 4

[Robert Longson [:longsonr]]

Attachment: diff -w patch

Only fixes pservers-pattern-04, looks like pservers-pattern-02 is some other issue

Comment 5

[Robert Longson [:longsonr]]

Attachment: standard patch

Comment 6

[Robert Longson [:longsonr]]

The patch does fix bug 589651 though.

Comment 7

[Jonathan Watt [:jwatt]]

Do you understand the use of MaxExpansion, Robert?

Comment 8

[Robert Longson [:longsonr]]

bug 384208. If a pattern is rotated then the bounding box can be bigger. Probably should try to convert one of the testcases from that bug into a reftest.

Comment 9

[Jonathan Watt [:jwatt]]

The MaxExpansion call is in the |else|, so it's used for patternContentUnits=userSpaceOnUse, not =objectBoundingBox.

I have to prepare for the SVG WG F2F tomorrow (taking place all next week), and since we're going to have to wait until after ff4 to land this anyways, I'll come back to this after the F2F.

Comment 10

[Robert Longson [:longsonr]]

Why are you worried about the MaxExpansion call? I haven't changed that.

Comment 11

[Jonathan Watt [:jwatt]]

Because I needed to understand the surrounding code and how the function works and is used as a whole to understand the change.

Comment 12

[Robert Longson [:longsonr]]

Attachment: hg changeset patch with reftest

Comment 13

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/4ff3dfaadd48