Closed Bug 64622 Opened 24 years ago Closed 24 years ago

No link found in: <font><a href="aaa.html"><font>aaa</font></a></font>

Categories

(Core :: DOM: HTML Parser, defect)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: ivo, Assigned: rickg)

References

(
URL
)

Details

(Keywords: regression, testcase, top100, Whiteboard: [fix in hand])

Attachments

(2 files)

Testcase, and hey don't blame me if Mozilla crashes on this one.
272 bytes, text/html
Details
Diff (patch) to fix the problem.
499 bytes, patch
Details | Diff | Splinter Review 
I noticed there were some links missing on www.anandtech.com and after some
trying it came down to this:

link in script

<font><a href="aaa.html"><font>Link to aaa.html</font></a></font>

is not found, but in

<font><a href="aaa.html">Link to aaa.html</a></font>

and in

<a href="aaa.html"><font>Link to aaa.html</font></a>

it is.


Mozilla daily build ID: 2001010720
I'm seeing this, too, in the rather awkward HTML on the front page, and many
other pages, of the Daily Telegraph newspaper (http://www.telegraph.co.uk/).
Linux build 2001010721.

Sounds like a parser issue. Changing component, marking confirmed based on
comments.

This works in a build a few hours older than the nightlies here, I strongly
suspect this is because of rickg's recent checkin.

rickg, confirm/deny?
Assignee: asa → harishd
Status: UNCONFIRMED → NEW
Component: Browser-General → Parser
Ever confirmed: true
QA Contact: doronr → janc
*** Bug 64628 has been marked as a duplicate of this bug. ***
I'm using build 2001010708 on WinNT4 Sp6b and that first link is working
perfectly for me. I will make a small testcase.
has noted on Bug 64628 this one also afects WinNT
I'm seeing this in the wild at http://www.nationalreview.com/ with Linux build
2001-01-08-06.  os <- all
OS: Windows 98 → All
Hardware: PC → All
Reassigning bug to rickg.
Assignee: harishd → rickg
Sounds similar to bug 64536, there's a testcase attached there that shows a
similar (the same?) bug w/in tables only.  If that is the same, the regression
keyword is probably not valid since NS6 has the same bug.
Looking...
Status: NEW → ASSIGNED
Testcase 2 of bug 64536 do to work with Mozilla daily build ID: 2001010720
(Win98SE) (also testcase 1 after saving it to separate file). Both contain 6
links and these are found.


Is this the same bug that plagues the Netscape.com homepage?
Ok -- I found the bug, and I'm working on a general solution. 
It seems that handling all the special cases has caused a simple case to be 
handled incorrectly. Sorry about that.
Fix in hand.
Whiteboard: [fix in hand]
Please check bug 64250 when this bug is fixed.  (Bug 64250 was happening before 
bug 64622 was introduced, I think, but they have the same testcase.)
*** Bug 64761 has been marked as a duplicate of this bug. ***
*** Bug 64773 has been marked as a duplicate of this bug. ***
*** Bug 37578 has been marked as a duplicate of this bug. ***
Care to attach the patch?

Attaching...

    
    

    
  
This breaks links on major sites, including netscape.com.  Can we get this 
reviewed?
Severity: major → critical

    
    

    
  
sr=buster

    
    

    
  
adding mostfreq and top100 keywords
Keywords: mostfreq, 
          
            top100
Summary: No link found in : <font><a href="aaa.html"><font>aaa</font></a></font> → No link found in: <font><a href="aaa.html"><font>aaa</font></a></font>

    
    

    
  
*** Bug 64898 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 64997 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 65005 has been marked as a duplicate of this bug. ***

    
    

    
  
rickg, this has sr and is creating a lot of extra work for incoming bug triage.
 is this fix landing anytime soon?

    
    

    
  
can someone else check this in?  

    
    

    
  
Rickg, the problem is in IsResidualStyleTag(), I think. Here is a revised patch.

Index: nsElementTable.cpp
===================================================================
RCS file: /cvsroot/mozilla/htmlparser/src/nsElementTable.cpp,v
retrieving revision 3.115
diff -u -w -r3.115 nsElementTable.cpp
--- nsElementTable.cpp  2001/01/08 03:37:13     3.115
+++ nsElementTable.cpp  2001/01/11 21:00:21
@@ -1921,6 +1921,7 @@
     case eHTMLTag_tt:
     case eHTMLTag_u:
       result=PR_TRUE;
+      break;

     case eHTMLTag_abbr:
     case eHTMLTag_acronym:

    
    

    
  
*** Bug 65073 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 65161 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 65182 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 65199 has been marked as a duplicate of this bug. ***

    
    

    
  
Maybe if the bug lives long enough, people will stop using the FONT element!

    
    

    
  
Oops, forgot to mention that the fix is in ( verify with 01/12/01 build ). 

Marking FIXED :)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED

    
    

    
  
verf.

Glad now that I can use mozillazine again :-) right asa!
Status: RESOLVED → VERIFIED

    
    

    
  
Bugs are verified on all platforms, and noted in the bug.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

    
  
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED

    
    

    
  
marking fixed

    
    

    
  
Thanks, finally I can upgrade again. :-)

May I suggest the following additional patch to prevent something like this
happen again?

--- nsElementTable.cpp  2001/01/11 21:31:03     3.116
+++ nsElementTable.cpp  2001/01/12 23:16:17
@@ -1936,6 +1936,8 @@ PRBool nsHTMLElement::IsResidualStyleTag
     case eHTMLTag_strong:
     case eHTMLTag_var:
       result=PR_FALSE;
+      break;
+
     default:
       break;
   };

And there is another missing break at line 2049 - don't know if this is
intentional.


    
    

    
  
*** Bug 65495 has been marked as a duplicate of this bug. ***

    
    

    
  
Ok, I can't reproduce this bug anymore. Verified.
Status: RESOLVED → VERIFIED

    
    

    
  
*** Bug 65692 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 65693 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 65781 has been marked as a duplicate of this bug. ***

    
    

    
  
The fix in this bug has introouced a regression (bug 66772). Reopening the bug,
as the patch is not good.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

    
    

    
  
The patch is correct to fix this bug and its duplicates. The problem in 66772 
could be completely a different problem. Marking this bug fixed.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED

    
    

    
  
Could be another problem, but backing out the fix for this bug fixes indeed bug
66772, so it looks that this bug is at least close related, or this bug has
revealed another parser bug.

    
    

    
  
updated qa contact.
QA Contact: janc → bsharma

    
    

    
  
Verified on:
build: 2000-03-07-10-Mtrunk
platform: WinNT

On the site http://www.anandtech.com, i can click on the link and the linked 
page loads fine. i hope this is what needs to be verified on this bug.
Status: RESOLVED → VERIFIED

    
    

    
      
  

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: