649595 - The Mac bundle name for all repos except m-c should be Mozilla Firefox

Status: RESOLVED WONTFIX

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

Similar to bug 649594 except for Mac OS X.

One thing I am concerned with this change is that each repo has its own CFBundleIdentifier as of bug 553073 landing. When changing channels this will change and if the bundle was the default browser it will no longer be the default browser. I *think* it would be best if all repos went back to hardcoding the CFBundleIdentifier with m-c using minefield and all others using firefox though a solution that handled other repos such as tracemonkey would be better.

Comment 1

[Sheila Mooney]

I spoke with Mayumi. She is ok with us simply using Firefox.app for the time being since using the Mozilla-Firefox.app will have issues and we really need someone who understands how mac bundles to fix this. We still want to have the Aurora.app changed to Firefox.app which is work that has to be resourced and scoped. This is no longer blocking on a product decision and it's now simply an engineering resource issue.

Comment 2

[Robert Strong (they/them - no direct email)]

for clarity, on channel change if the install was default browser it will no longer be default browser since the CFBundleIdentifier will also change.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I don't think we should change anything related to the bundle filename. Users who download Aurora.app can deal with the bundle name not matching the product name if they channel switch.

CFBundleIdentifier is a different question, because of its impact on the default browser setting. I don't think it's tied to the bundle filename itself in any way though, right?

Comment 4

[Robert Strong (they/them - no direct email)]

I agree and think that is the best we can do... I'll get confirmation from Jay on Monday.

The CFBundleIdentifier isn't tied to the bundle name... it is set when building.
For example
nightly = org.mozilla.nightly
aurora = org.mozilla.aurora

Comment 5

[:Gavin Sharp [email: [e-mail]]]

We had good reasons to use different bundle identifiers when we did that (bug 553073). I'm not sure that channel changing affects that decision much.

The default browser case handling is troublesome. What actually happens on the upgrade in the common case (only Firefox installed)? Does the default browser switches back to Safari?

Comment 6

[Robert Strong (they/them - no direct email)]

(In reply to comment #5)
> We had good reasons to use different bundle identifiers when we did that (bug
> 553073). I'm not sure that channel changing affects that decision much.
Sure. What we do on Windows is launch a post update process that fixes up the settings when things like this change so that is an option.

> The default browser case handling is troublesome. What actually happens on the
> upgrade in the common case (only Firefox installed)? Does the default browser
> switches back to Safari?
I haven't checked how Mac handles default apps under this scenario... I'll check later tonight. Turns out that enough of the AUS changes have landed to go from aurora to nightly to test this by changing the channel to Beta in the ui, setting the app.update.desiredChannel pref to the nightly, checking for updates, and applying the update.

Comment 7

[Sheila Mooney]

Gavin,

We would like to have the app names be consistent for the channels....

+ Firefox Nightly
+ Firefox Aurora
+ Firefox
+ Firefox

Comment 8

[Sheila Mooney]

To be clear, this is the product name that appears to the user.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

The product name that appears where? There are a few places:

a) Mac bundle name (e.g. Nightly.app)
b) UI "displayname" (what shows up in the Mac menu bar when the app is open, and other places in the UI where we refer to "Firefox")

I thought, when we discussed this last week that you were only referring to a), but now it seems like you're talking about both a) and b).

Having unbranded builds include the word "Firefox" (even in just the filename) is a pretty significant change. It means that anyone generating custom builds will get something that references "Firefox" - we've tried hard to avoid that in the past. Our trademark policy doesn't allow the use of "Firefox" at all unless you get explicit permission.

Comment 10

[Sheila Mooney]

Ok, there is a bunch of confusion on the this. I will clear it up and get back to you.

Comment 11

[Robert Strong (they/them - no direct email)]

It has been decided that channel switching will be removed in bug 659972 so resolving wontfix. Naming issues that don't have to do with channel switching will be handled in bug 659321.

Comment 12

[Sheila Mooney]

We don't need to track this anymore.